Skip to content

Show messageBox when delete trashedNote#280

Merged
Rokt33r merged 1 commit intoBoostIO:masterfrom
funzin:show-dialog-when-delete-trashed-note
Jan 10, 2020
Merged

Show messageBox when delete trashedNote#280
Rokt33r merged 1 commit intoBoostIO:masterfrom
funzin:show-dialog-when-delete-trashed-note

Conversation

@funzin
Copy link
Copy Markdown
Contributor

@funzin funzin commented Jan 10, 2020

Problem

I tried following steps with BoostNote App.

  1. Select Trashed Tab
  2. Select a Trashed Note and then right click(Open menu)
  3. Select Delete button

but I didn't see any reaction from BoosNote😞

Changes

Show messageBox when delete trashedNote🗑(like select trash icon)
If you select Delete a Note, the note is purged.

CurrentNote is not affect by my implementation.

GIF

demo

@claassistantio
Copy link
Copy Markdown

claassistantio commented Jan 10, 2020

CLA assistant check
All committers have signed the CLA.

@Rokt33r Rokt33r merged commit 5b11bbf into BoostIO:master Jan 10, 2020
@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Jan 10, 2020

LGTM! Thanks for contributing!

@Rokt33r Rokt33r added this to the v0.1.4 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants