checkboxes checkable in previewer#353
Closed
pfftdammitchris wants to merge 1 commit intoBoostIO:masterfrom
Closed
Conversation
Member
|
@pfftdammitchris I think it looks good to me. We could merge this after some polishing(Removing logging and extracting the checkbox component). So I'll let you finish this PR. Once you've finished, please ping me again so I can review and merge this quickly. |
|
|
Contributor
|
@tcznode Could you sign the CLA? |
Member
|
@pfftdammitchris Is @tcznode your github account? If so, please do CLA sign. If not, I'm going to reset @tcznode 's commit. |
pfftdammitchris
force-pushed
the
checkboxes
branch
from
796c1f3 to
f8e5264
Compare
Contributor
Author
|
no longer WIP didn't notice the tcznode. sorry about that.
|
pfftdammitchris
changed the title
Merged
Member
|
I created another pr for this because I wasn't able to fix your branch directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace from #287 (tried to re-open)
references #283
fixes #287
i wanted to leave it open here and see what u guys have in mind to approach this. currently where its at, this works but only the first time. i remember wanting to abstract these details into a separate hook but wasnt sure if it was heading a different direction from the flow