Skip to content

Code styling#359

Merged
Rokt33r merged 4 commits intoBoostIO:masterfrom
arcturus140:codeStyling
Apr 2, 2020
Merged

Code styling#359
Rokt33r merged 4 commits intoBoostIO:masterfrom
arcturus140:codeStyling

Conversation

@arcturus140
Copy link
Copy Markdown
Contributor

this Pullrequest changes styling for code elements.

before

dark
solarized

after

stiched

@claassistantio
Copy link
Copy Markdown

claassistantio commented Feb 16, 2020

CLA assistant check
All committers have signed the CLA.

@ZeroX-DG
Copy link
Copy Markdown
Member

Can we reduce the amount of duplicate code like this?

p code, li code {
  padding: 2px;
  border-width: 1px;
  border-style: solid;
  border-radius: 5px;
}
.dark p code,
.dark li code
{  
  background-color: rgba(255, 255, 255, 0.12); 
  border-color: rgba(255, 255, 255, 0.3);
  color: #03C588;
}
.auto p code,
.auto li code
{
  background-color: #F9F9F9;
  border-color: rgba(0, 0, 0, 0.26);
  color: #03C588;
}
.light p code,
.light li code
{
  background-color: #F9F9F9;
  border-color: rgba(0, 0, 0, 0.26);
  color: #03C588;
}
.sepia p code,
.sepia li code
{
  background-color: #efe8d6;
  border-color: rgba(0, 0, 0, 0.26);
  color: #F77942;
}
.solarizedDark p code,
.solarizedDark li code
{
  background-color: rgba(255, 255, 255, 0.12);
  border-color: rgba(255, 255, 255, 0.3);
  color: #36abe3;
}

@arcturus140
Copy link
Copy Markdown
Contributor Author

sure, done!

@arcturus140 arcturus140 requested a review from ZeroX-DG February 16, 2020 22:11
@ZeroX-DG
Copy link
Copy Markdown
Member

Very nice, I'll test this when I get home

@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Feb 21, 2020

Thanks for the pr. I'll review it soon.

@Rokt33r Rokt33r merged commit 75427bf into BoostIO:master Apr 2, 2020
@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Apr 2, 2020

I've merged this pr but I'm going to try fix this again with #392 .

@arcturus140 arcturus140 deleted the codeStyling branch April 4, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants