Skip to content

French#364

Merged
Rokt33r merged 4 commits intoBoostIO:masterfrom
Hadrien-lcrx:french
Mar 3, 2020
Merged

French#364
Rokt33r merged 4 commits intoBoostIO:masterfrom
Hadrien-lcrx:french

Conversation

@Hadrien-lcrx
Copy link
Copy Markdown
Contributor

  • Added French translation
  • Minor corrections to Spanish translation
  • Renaming esEs.ts in src/locales to esES.ts for consistency. Modified corresponding import statements in src/lib/i18n.ts
  • Note: In src/locales, on line 60 of any .ts files, you have a 'note.date'key. It's "ago" in English, which would render as "20 days ago". In French, it's "il y a", which would render as "Il y a 20 jours". So the locale ends up in front of the value instead of after. Same thing in Spanish: "Hace 20 días". I would verify how this specific locale renders in these languages, to make sure language specific grammar is respected.

@Hadrien-lcrx
Copy link
Copy Markdown
Contributor Author

Hadrien-lcrx commented Feb 25, 2020

  • I have signed the CLA, so I'm not sure why the verification is still pending.

Screen Shot 2020-02-25 at 09 46 32

  • My address, although private, is added to my GitHub settings, so I'm not sure why claassistantio says that I seem not to be a GitHub user.

@Hadrien-lcrx Hadrien-lcrx requested review from Rokt33r and kazup01 and removed request for Rokt33r February 25, 2020 08:48
@kazup01 kazup01 removed their request for review February 25, 2020 08:49
@Hadrien-lcrx Hadrien-lcrx mentioned this pull request Feb 26, 2020
21 tasks
@Hadrien-lcrx
Copy link
Copy Markdown
Contributor Author

CLA issue fixed.

@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Feb 26, 2020

Thanks for the contribution! I'll ask my friend to review this.

Comment thread src/locales/frFR.ts Outdated
Comment thread src/locales/frFR.ts Outdated
Comment thread src/locales/frFR.ts Outdated
Comment thread src/locales/frFR.ts Outdated
Comment thread src/locales/frFR.ts Outdated
@Hadrien-lcrx
Copy link
Copy Markdown
Contributor Author

@Davy-c Thank you, I just committed the edits required.

@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Mar 3, 2020

@Hadrien-lcrx .git files are included from the last commit. Could you discard them?

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Hadrien-lcrx
Copy link
Copy Markdown
Contributor Author

@Rokt33r done!

@Rokt33r Rokt33r merged commit 706aeba into BoostIO:master Mar 3, 2020
@Hadrien-lcrx Hadrien-lcrx deleted the french branch March 4, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants