Merged
Conversation
Contributor
Author
Contributor
Author
|
CLA issue fixed. |
Member
|
Thanks for the contribution! I'll ask my friend to review this. |
Davy-c
reviewed
Feb 28, 2020
Contributor
Author
|
@Davy-c Thank you, I just committed the edits required. |
Member
|
@Hadrien-lcrx .git files are included from the last commit. Could you discard them? |
Contributor
Author
|
@Rokt33r done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

esEs.tsinsrc/localestoesES.tsfor consistency. Modified corresponding import statements insrc/lib/i18n.tssrc/locales, on line 60 of any.tsfiles, you have a'note.date'key. It's "ago" in English, which would render as "20 days ago". In French, it's "il y a", which would render as "Il y a 20 jours". So the locale ends up in front of the value instead of after. Same thing in Spanish: "Hace 20 días". I would verify how this specific locale renders in these languages, to make sure language specific grammar is respected.