Fix broken build#378
Merged
Rokt33r merged 3 commits intoBoostIO:masterfrom Mar 26, 2020
sbencoding:master
Merged
Conversation
|
|
Contributor
Author
|
Filename issue fixed in f4012ec |
Member
|
@sbencoding Yeah, I'm going to merge this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I tried to build the project but ran into several problems.
In this PR I post the changes I've made to be able to build the project.
esEs.tstoesES.tsbecausesrc/lib/i18n.tsreferenced the file with the big S at the end..envfile in the project root. So contributors would need to create an empty one for the build to run. I'm not really familiar with the.envsystem used here, so I guess you could provide a better documentation for this problem than I did. My understanding is that you use that file for storing tokens for analytics but I didn't investigate it thoroughly.