General overhaul of the de-localization#430
General overhaul of the de-localization#430Rokt33r merged 5 commits intoBoostIO:masterfrom moltenbit:master
Conversation
General overhaul of the de-localization. I feel like ```Speicherort``` as the main translation for ```storage``` is generally correct, but quite unusual. You should think about maybe changing it to something like ```Notizbuch = Notebook``` on many occasions. If you wish to implement that feel free to ask me to translate it. 'note.date': currently it says ```38 minutes her``` but it should either be ```38 Minuten her``` or ```vor 38 Minuten```. IMO the second one is better, but I think more code adjustment is necessary somewhere else to rephrase the wording.
|
|
|
are storage locations deleted permanentely or simply unlinked? I am not sure about the behaviour for each storage type. This requires some clarification. |
arcturus140
left a comment
arcturus140
left a comment
There was a problem hiding this comment.
I have one suggestion, LGTM otherwise.
| 'tag.removeMessage': 'Das Etikett wird von allen Notizen entfernt.', | ||
| 'tag.tag': 'Tag', | ||
| 'tag.remove': 'Tag löschen', | ||
| 'tag.removeMessage': 'Der Tag wird von allen Notizen entfernt.', |
There was a problem hiding this comment.
Der and Das Tag is both correct according to the sources I looked at
There was a problem hiding this comment.
this is correct. This is an entirely personal preference. I prefer the latter. I'll leave it to you.
| //Billing | ||
| 'billing.billing': 'Billing', | ||
| 'billing.message': 'Bitte melde dich an um deinen Plan zu ugpraden.', | ||
| 'billing.message': 'Bitte melde dich an, um deinen Plan zu ugpraden.', |
There was a problem hiding this comment.
suggestion: zu erweitern
| @@ -145,19 +145,19 @@ export default { | |||
| // Preferences MarkdownTab | |||
| 'preferences.previewStyle': 'Vorschau Style', | |||
| 'preferences.markdownCodeBlockTheme': 'Code Block Theme', | |||
| 'storage.renameMessage': 'Name des Speicherorts ändern', | ||
| 'storage.remove': 'Speicherort entfernen', | ||
| 'storage.removeMessage': 'Speicherort wird von App entknüpft', | ||
| 'storage.removeMessage': 'Speicherort wird gelöscht', |
There was a problem hiding this comment.
are they really deleted? In the old app they where merely unlinked. gelöscht would cause confusion, then.
If they aren't, which I don't know if that is the case, then Verknüpfung zum Speicherort entfernen would be better.
Yes, the second one is correct. I prefer |
small adjustments thanks to @arcturus140
|
Things that need clarification:
|
|
as far as this PR is concerned, you should assume an unlink. discussion on your bullet points can be continued here but at the end of the day a separate issue is required since every language scheme is affected. |
Done. Ready for pull. |
|
it doesn't compile. apparently you're short on a string terminator or a comma. |
|
I'll give this PR my 100% 🇩🇪 rating. thank you for your contribution |
ZeroX-DG
left a comment
ZeroX-DG
left a comment
There was a problem hiding this comment.
Alright, thanks for this PR guys. I'll approve it
ZeroX-DG
added
approved 👍
5 participants
General overhaul of the de-localization.
I feel like
Speicherortas the main translation forstorageis generally correct but quite unusual. You should think about maybe changing it to something likeNotizbuch = Notebookon many occasions. If you wish to implement that feel free to ask me to translate it.'note.date': currently it says e.g.
38 minutes herbut it should either be38 Minuten herorvor 38 Minuten. IMO the second one is better, but I think more code adjustment is necessary somewhere else to rephrase the wording.Btw: where can I translate other things like e.g.
Storage SettingsorRemove Storagewhen you edit your storage?