Skip to content

RPM build target | #441#445

Merged
Rokt33r merged 1 commit intoBoostIO:masterfrom
jhdcruz:rpm-build
May 1, 2020
Merged

RPM build target | #441#445
Rokt33r merged 1 commit intoBoostIO:masterfrom
jhdcruz:rpm-build

Conversation

@jhdcruz
Copy link
Copy Markdown
Contributor

@jhdcruz jhdcruz commented Apr 27, 2020

Requires rpm build essentials

The project's electron-builder build script are based on the current architecture/OS of the user, so it probably needs redhat-based machines (ex. Fedora, CentOS, etc.) to achieve .rpm builds.


I also suggest seperating electron-builder configurations to its own dedicated file: electron-builder.yml to avoid the cluttering of package.json.

json, json5, toml or js (exported configuration or function that produces configuration) formats also supported.

@jhdcruz jhdcruz marked this pull request as ready for review April 27, 2020 13:49
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Apr 29, 2020
@ZeroX-DG ZeroX-DG requested a review from Rokt33r April 29, 2020 01:09
@Rokt33r Rokt33r linked an issue May 1, 2020 that may be closed by this pull request
@Rokt33r Rokt33r added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels May 1, 2020
@Rokt33r Rokt33r added this to the v0.5.0 milestone May 1, 2020
@Rokt33r Rokt33r merged commit 05299bd into BoostIO:master May 1, 2020
@jhdcruz jhdcruz deleted the rpm-build branch May 1, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support RPM package

3 participants