Fixed style bugs on tags | #330#477
Closed
jhdcruz wants to merge 4 commits intoBoostIO:masterfrom
jhdcruz:tags_bugfix
Closed
Fixed style bugs on tags | #330#477jhdcruz wants to merge 4 commits intoBoostIO:masterfrom jhdcruz:tags_bugfix
jhdcruz wants to merge 4 commits intoBoostIO:masterfrom
jhdcruz:tags_bugfix
Conversation
Member
|
Fixed in #487 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix style bugs on tags:
Prevent word-break on
CN,KRand other characters.Add
maxLengthto prevent "immortal" tags. (conflicts with the new update)Addresses Issue #330
c5bbe8a:
Max length on tagsI setmaxLengthto25after testingLLLLLL....,TTTTTT....wide letters on it and came to a conclusion to set it to25. This is a possible fix to the problem of immortal tags.Personally, I think this is a good move to prevent long tag abuse (although I know it's the user's decision).