Skip to content

Update app translation text#626

Merged
Rokt33r merged 4 commits intoBoostIO:masterfrom
AlexandreAguido:extract_hardcoded_app_text
Oct 29, 2020
Merged

Update app translation text#626
Rokt33r merged 4 commits intoBoostIO:masterfrom
AlexandreAguido:extract_hardcoded_app_text

Conversation

@AlexandreAguido
Copy link
Copy Markdown
Contributor

While working on the app translation to portuguese I i didn't found all the text that is need to translate, so with this PR I'm adding the hardcoded text that i found to the english locale file, which I'm using for portuguese translation

add hardcoded text found on the app to enUS locale file
@Flexo013 Flexo013 self-requested a review September 29, 2020 19:43
@Flexo013 Flexo013 self-assigned this Sep 29, 2020
@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Sep 29, 2020
@Flexo013 Flexo013 removed their request for review September 29, 2020 19:43
Copy link
Copy Markdown
Contributor

@Flexo013 Flexo013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Thanks for your contribution!

@Flexo013 Flexo013 added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Oct 4, 2020
@ramonbrugman
Copy link
Copy Markdown

....

@Rokt33r Rokt33r merged commit 7c59fb8 into BoostIO:master Oct 29, 2020
@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Oct 29, 2020

Thanks! @AlexandreAguido

@ramonbrugman
Copy link
Copy Markdown

Rokteer can u maybe contact me private i need some strictly intell about some repo's

@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Feb 22, 2021

@ramonbrugman
Copy link
Copy Markdown

Bro can u add me by email adres? ramonbrugmans@gmail.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants