Skip to content

Hompage Spanish translation (#462)#677

Merged
Rokt33r merged 5 commits intoBoostIO:masterfrom
igorer88:master
Dec 14, 2020
Merged

Hompage Spanish translation (#462)#677
Rokt33r merged 5 commits intoBoostIO:masterfrom
igorer88:master

Conversation

@igorer88
Copy link
Copy Markdown
Contributor

@igorer88 igorer88 commented Nov 9, 2020 •
edited
Loading

  • Homepage Spanish translation for PR #462

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Flexo013
Flexo013 reviewed Nov 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Flexo013 Flexo013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and my limited Spanish knowledge 😅

@igorer88 Do you know any other Spanish dev that could double check these translations?

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Nov 12, 2020
@igorer88
Copy link
Copy Markdown
Contributor Author

igorer88 commented Nov 12, 2020 •
edited
Loading

@Flexo013 Yeah sure. I can ask for a double check. ✔️✔️

manuelvieda
manuelvieda reviewed Nov 15, 2020
View reviewed changes
Comment thread homepage/locales/es.ts
Comment thread homepage/locales/es.ts
@igorer88
Copy link
Copy Markdown
Contributor Author

igorer88 commented Nov 16, 2020

@Flexo013 Double checked.

@saxc saxc mentioned this pull request Nov 21, 2020
Merged
saxc
saxc reviewed Nov 21, 2020
View reviewed changes
Comment thread homepage/locales/es.ts
@Flexo013 Flexo013 added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Dec 12, 2020
@Rokt33r Rokt33r merged commit d92c111 into BoostIO:master Dec 14, 2020
@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Dec 14, 2020

Thanks! Although we temporarily disabled the localization. Your work will be applied to the new homepage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Flexo013 Flexo013 Flexo013 left review comments

+2 more reviewers

@saxc saxc saxc left review comments

@manuelvieda manuelvieda manuelvieda left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@igorer88 @CLAassistant @Rokt33r @Flexo013 @saxc @manuelvieda