Merged
Conversation
Merged
Rokt33r
requested changes
Jan 2, 2021
| async renameTag(currentTagName: string, newTagName: string): Promise<void> { | ||
| const currentTag = await this.getTag(currentTagName) | ||
| if (currentTag == null) | ||
| return |
| <NavigatorButton | ||
| iconPath={mdiDotsVertical} | ||
| onClick={openTagContextMenu(tagName)} | ||
| /> |
Rokt33r
force-pushed
the
allow-renaming-tags
branch
from
4f1fcc5 to
9d73bf0
Compare
Member
|
I've refactor the codemyself. Please check 9d73bf0! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow renaming tags as requested in #324 (https://github.com/BoostIO/BoostNote.next/projects/3#card-33058499).
This feature also adds
Controlbutton toTagListFragment, meaning that three vertical dots will appear next to the tags in the list menu, showing 'Rename Tag' and 'Remove Tag' options. This way, web browser users will be able to rename tags, because they cannot right click on the tag list item.Also added analytics event
renameTag: 'tags.renamefor tracking.Added automated tests to
store.spec.tsandPouchNoteDb.spec.tsto verify renaming functionality.Manually tested: