Skip to content

Fix bug for renaming folders in file system database#748

Merged
Rokt33r merged 1 commit intoBoostIO:masterfrom
Komediruzecki:bugfix/rename-folder-regexp-escapes
Dec 31, 2020
Merged

Fix bug for renaming folders in file system database#748
Rokt33r merged 1 commit intoBoostIO:masterfrom
Komediruzecki:bugfix/rename-folder-regexp-escapes

Conversation

@Komediruzecki
Copy link
Copy Markdown
Contributor

Fix bug for renaming folders in file system database (#747)

  • Add escape for "[" character in regex escape characters
  • Update FSNoteDb to use the regex escapes while renaming folder

Todo:

  • After operation is finished/failed, it would be nice to show user a push message/notification of the successfuly/failed rename/removal

Test

  • In electron Linux App (dev)
  • In electron Linux App production version (appImage)

Add escape for "[" character in regex escape characters
Update FSNoteDb to use the regex escapes while renaming folder
@Komediruzecki Komediruzecki added the awaiting review ❇️ Pull request is awaiting a review. label Dec 30, 2020
@Rokt33r Rokt33r merged commit 3a9ffd4 into BoostIO:master Dec 31, 2020
@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Dec 31, 2020

Awesome!!

@Rokt33r Rokt33r added this to the v0.13 milestone Dec 31, 2020
@Komediruzecki Komediruzecki removed the awaiting review ❇️ Pull request is awaiting a review. label Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants