Improve export consistency between HTML and PDF types#761
Merged
Rokt33r merged 1 commit intoBoostIO:masterfrom Mar 20, 2021
Merged
Conversation
Add remark-admonitions for html generation Update metadata for html generation Refactor HTML export to use custom HTML generated previously for PDF only Refactor export functions Replace preferences object with actual needed preferences Update conversion functions for saving note document with shortcut Export css attachments for HTML Export css stylesheets Link css stylesheets in HTML string for HTML export Refactor PDF links update in markdown (remove HTML handling) Refactor shortcut saving HTML and Markdown - Add saveFolder and saveName Update logic for production paths (use API and dev variable) Add katex fonts exporting and katex.min.css instead of jsdeliver link
Komediruzecki
force-pushed
the
feature/improve-export-consistency
branch
from
560c34c to
9254c9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve export consistency between HTML and PDF types (#754)
Error handling:
Preview:
The export structure as described in #754
HTML rendering of admonitions:
Exported HTML and then printed PDF in Firefox (emojis work):
MarkdownFunctionalityFirefoxRendering.pdf
HTML & Assets:
Markdown Functionality Test.zip
Tests:
Tried exporting with shortcut
ctrl+swith type Markdown, PDF and HTMLTried exporting with export buttons with type Markdown, PDF, and HTML
In electron Linux App (dev)
In electron Linux App production version (appImage)