Skip to content

UI: Adjusted Import Modal Styles#806

Merged
Rokt33r merged 1 commit intomasterfrom
ui-import-modal
Feb 23, 2021
Merged

UI: Adjusted Import Modal Styles#806
Rokt33r merged 1 commit intomasterfrom
ui-import-modal

Conversation

@ellekasai
Copy link
Copy Markdown
Contributor

I adjusted the styles of the import modal.

  • Adjusted spacing
  • Adjusted font sizes
Before After
CleanShot 2021-02-20 at 15 33 23 CleanShot 2021-02-20 at 15 44 18

@Komediruzecki
Copy link
Copy Markdown
Contributor

Komediruzecki commented Feb 20, 2021

Maybe a note on the text above.

'Select how you want to import files ( 5Mb max per file )'

The parentheses never have inner spaces, only outer.
Unit and number are always separated by a space. If we want to be exact is 'Mb' megabyte or megabit, mebibyte or mebibit?

It would be nicer:

'Select how you want to import files (5 MB max per file)'
(assuming MB is megabyte in computer science = 1 MB = 1000000 B or 1 Mebibyte = 1024 * 1024 B)

Maybe this shouldn't be in this PR as a fix, but maybe another

@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Feb 23, 2021

@Komediruzecki Thanks for the suggestion. I'll fix it by myself!

@Rokt33r Rokt33r merged commit 7911dc5 into master Feb 23, 2021
@Rokt33r Rokt33r deleted the ui-import-modal branch February 23, 2021 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants