Skip to content

Add Tooltip component#810

Closed
Komediruzecki wants to merge 1 commit intoBoostIO:masterfrom
Komediruzecki:feature/improve-tooltip-handling
Closed

Add Tooltip component#810
Komediruzecki wants to merge 1 commit intoBoostIO:masterfrom
Komediruzecki:feature/improve-tooltip-handling

Conversation

@Komediruzecki
Copy link
Copy Markdown
Contributor

@Komediruzecki Komediruzecki commented Feb 23, 2021

Add Tooltip component (#552)

  • Add tooltip component
  • Add basic portal component for tooltip
  • Add tooltip component in navigator buttons
  • Add tooltip for button components
  • Add translation for button tooltip texts
  • Add tooltip delay
  • Show tooltip arrow on edges at the correct location
  • Fix tooltip arrow center position issue

Few examples of how it looks:
TooltipWorkspaceNewNoteButton
TooltipOpenContextView
TooltipPathTooltip
TooltipAddLabelSolarizedDark
TooltipEditTitleSolarizedDark
TooltipIndentOptionsBottomBar

I left the coloring and styling to whoever can make it work and used tooltip background color available in the theme.
In this (blackish) color arrow is sometimes not seen so clearly and on a dark background, it would also be a bit harder to spot. Meaning separate colors for each theme (black/white/sepia) could be used, an example of that would be something like this:

TooltipNavigateToFolder
TooltipShowMdPreviewSepia

The non-transparent color would also help I think.

Tested in

  • Local dev
  • Production AppImage (Linux)

@Komediruzecki Komediruzecki added the awaiting review ❇️ Pull request is awaiting a review. label Feb 23, 2021
Add tooltip component
Add basic portal component for tooltip
Add tooltip component in navigator buttons
Add tooltip for button components
Add translation for button tooltip texts
Add tooltip delay
Show tooltip arrow on edges at correct location
Fix tooltip arrow center position issue
@Komediruzecki Komediruzecki force-pushed the feature/improve-tooltip-handling branch from d4e9275 to a2881c7 Compare March 16, 2021 21:30
@Komediruzecki
Copy link
Copy Markdown
Contributor Author

@Rokt33r we could use this code to improve cloud tooltips, when adding tooltip alongside edge of screen, the whole tooltip can not be viewed, Maybe I should rebase this PR and add improvements to shared tooltip component and merge this instead?

@Komediruzecki
Copy link
Copy Markdown
Contributor Author

Closing in favor of new local space only repository, will be reopened and rebased there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review ❇️ Pull request is awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant