Merged
Conversation
08718dd to
8d3a0f8
Compare
Rokt33r
reviewed
May 25, 2021
| import { SerializedUser } from '../../cloud/interfaces/db/user' | ||
| import { usePage } from '../../cloud/lib/stores/pageStore' | ||
|
|
||
| export function withLiveUser< |
Member
There was a problem hiding this comment.
We can make a hook useLiveUser which using the same hooks of withLiveUser
So I would like to use the below code.
export function useLiveUser(user: User) {
const { permissions } = usePage()
const normalizedUser = useMemo(() => {
if (permissions == null) {
return user
}
const permission = permissions.find((permission) => permission.user.id)
return permission != null ? permission.user : user
}, [user, permissions])
}
const LiveUserIcon = (props: Exclude<UserIconProps, 'user'>) => {
const liveUser = useLiveUser()
return <UserIcon {...props} user={liveUser}/>
}By doing this, we don't have to introduce another pattern HOC.
And the hook pattern is much easier to compose with other hooks while composing HOCs are quite difficult to understand and control.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIxes
Closedthreads to outdated