Skip to content

When printing#2077

Open
Matts966 wants to merge 3 commits intoBoostIO:masterfrom
Matts966:whenPrinting
Open

When printing#2077
Matts966 wants to merge 3 commits intoBoostIO:masterfrom
Matts966:whenPrinting

Conversation

@Matts966
Copy link
Copy Markdown

@Matts966 Matts966 commented Jun 13, 2018

No description provided.

@sosukesuzuki sosukesuzuki self-requested a review June 14, 2018 01:20
@sosukesuzuki sosukesuzuki added the awaiting review ❇️ Pull request is awaiting a review. label Jun 14, 2018
@sosukesuzuki
Copy link
Copy Markdown
Contributor

sosukesuzuki commented Jun 14, 2018

@Matts966 I don't know what you want to.:cry:
Please write a description.:pray:

@Matts966
Copy link
Copy Markdown
Author

Matts966 commented Jun 14, 2018

Sorry, I forgot to write a description...

I would like to remove the padding for scrolling preview when printing notes(or make pdf) , because the padding make the last page of pdf white one.

Also, when printing, I would like to see code even if a line of it is too long to see without scrolling. Pdf docs and papers can not be scrolled, so I break the line when it is long.

sosukesuzuki
sosukesuzuki requested changes Jun 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@sosukesuzuki sosukesuzuki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm my review!
However, showing line numbers is broken by DOM structure of code block. like below:
2018-06-25 17 09 29
I want you to fix it.

Comment thread browser/components/MarkdownPreview.js Outdated
display: none
}
pre.CodeMirror>code {
white-space: pre-wrap;
Copy link
Copy Markdown
Contributor

@sosukesuzuki sosukesuzuki Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add word-wrap: break-word;.
Now, output PDF is broken like below:
2018-06-25 17 06 00

@Matts966
Copy link
Copy Markdown
Author

Matts966 commented Jun 25, 2018

Thank you for your review!
It may take time for me to fix it, because I don't know what is best for this problem...

I have two ideas about this.

  1. adding <br> tag to the number of code line.
  2. using other codemirror type? like CodeEditor.

Sorry for my confirmation.
Thank you.

@Matts966
Copy link
Copy Markdown
Author

Matts966 commented Jun 25, 2018

Also, it is not good to break DOM structure and I reverted the commit.

@sosukesuzuki
Copy link
Copy Markdown
Contributor

sosukesuzuki commented Jun 26, 2018

@Matts966 I think the second one of your ideas is great:+1:
We should change DOM structure of code block in preview like CodeEditor.

@Rokt33r
Copy link
Copy Markdown
Member

Rokt33r commented Jul 17, 2018

@Matts966 @sosukesuzuki Could you tell me the current status of this pr?

@Matts966 Matts966 closed this Jul 17, 2018
@Matts966 Matts966 reopened this Jul 17, 2018
@Matts966
Copy link
Copy Markdown
Author

Matts966 commented Jul 17, 2018 •
edited
Loading

Sorry for my being late and a mistake to close pr.
I'm currently so busy with my work, and the request will not be satisfied soon.
The modification causing a bug was already reverted.

@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki requested changes

Assignees

No one assigned

Labels

awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Matts966 @sosukesuzuki @Rokt33r