Added the reorder functionality to storage in the side navigation #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroX-DG
reviewed
Dec 8, 2018
browser/main/SideNav/index.js
Outdated
| const isFolded = config.isSideNavFolded | ||
|
|
||
| let itemIndex = -1 | ||
| const storageList = data.storageMap.map((storage, key) => { |
Member
There was a problem hiding this comment.
Can you explain how can you use the map function here? I thought storageMap was a map and it doesn't have map function? The feature works great, but I'm not quite understand there 😄
Contributor
Author
There was a problem hiding this comment.
Yes, the storageMap was a map, but it is not the javascript built-in map, it was the MutableMap from Dick Choi and it provides the map function, please refer here: MutableMap
ZeroX-DG
added
awaiting changes 🖊️
ZeroX-DG
approved these changes
Dec 14, 2018
ZeroX-DG
added
awaiting changes 🖊️
richardtks
force-pushed
the
re-order-storage
branch
from
a43359d to
253480b
Compare
Contributor
|
@richardtks Could you provide an example of how this is handled when the sidebar is collapsed? |
richardtks
force-pushed
the
re-order-storage
branch
from
253480b to
3be7d9c
Compare
Contributor
Author
|
@Flexo013, For the collapsed side bar, re-order is not allowed as the there is no space for the handler to show in the side navigation. Here is how it looks like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
Issue fixed
#1910
Type of changes
Checklist: