Implement drag and drop based order in sidebar for local space#1
Merged
Implement drag and drop based order in sidebar for local space#1
Conversation
Add array move lib Implemented orderedIds and DnD handling Add logic for moving note or doc into note target Add basic Database updates and API for orderedIds changes Implement ordered IDs initialization in storages Implement ordered IDs initializatio only in FSNote Remove excess function from createStore Updated handling of pouch DB in createStore Add create note update for parent folder ordered IDs Fix direct subfolders rather than all for create subfolders function Add implementation of trash/untrash note workspace orderedIds Update rename folder to update ordered IDs as well Implement createNote update of ordered IDs (workspace) Implement createFolder update of ordered IDs (workspace and parent folders) Implement folder reordering Implement moving of folders across different folder Refactor folder IDs to use real IDs Initialize real IDs (only FSNoteDB) Update rename folder so that it handles realIDs updates (previous and new parent folders ordered IDs update) Refactor code to use root folder instead of workspace ordered Ids Refactor and update for loading of storages Some improvements on loading multiple storages and some fails Add folder realID changing instead of reusing (also previous ordered IDs should be persisted on folder rename) Add handling of trash/untrash regarding ordered Ids Some ordered IDs bugfixes Remove console logs (most of them) Fix bug with parallel execution and parent folder creation on rename folder upsert folder calls Remove note id set from local space Fix bug with hiding items in sidebar (invalid key provided on callback) Assess some todos Update storages list data key Add order ID removal in purge note Fix sidebar tree ordered IDs handling
Komediruzecki
commented
Aug 4, 2021
| @@ -1,5 +1,5 @@ | |||
| export const preferencesKey = 'note.boostio.co:preferences' | |||
| export const storageDataListKey = 'note.boostio.co:storageDataList' | |||
| export const storageDataListKey = 'note.boostio.co:localStorageDataList' | |||
Collaborator
Author
There was a problem hiding this comment.
@Rokt33r anything to be careful about with this change? Users need to load all storages again. We should probably Unsupported storage page was already discarded, so maybe some message or similar to tell user that the loaded storage is not supported?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also introduces few key changes and bugfixes:
Add array move lib
Implemented orderedIds and DnD handling
Add logic for moving note or doc into note target
Add basic Database updates and API for orderedIds changes
Implement ordered IDs initialization in storages
Implement ordered IDs initializatio only in FSNote
Remove excess function from createStore
Updated handling of pouch DB in createStore
Add create note update for parent folder ordered IDs
Fix direct subfolders rather than all for create subfolders function
Add implementation of trash/untrash note workspace orderedIds
Update rename folder to update ordered IDs as well
Implement createNote update of ordered IDs (workspace)
Implement createFolder update of ordered IDs (workspace and parent folders)
Implement folder reordering
Implement moving of folders across different folder
Refactor folder IDs to use real IDs
Initialize real IDs (only FSNoteDB)
Update rename folder so that it handles realIDs updates (previous and new parent folders ordered IDs update)
Refactor code to use root folder instead of workspace ordered Ids
Refactor and update for loading of storages
Some improvements on loading multiple storages and some fails
Add folder realID changing instead of reusing (also previous ordered IDs should be persisted on folder rename)
Add handling of trash/untrash regarding ordered Ids
Some ordered IDs bugfixes
Remove console logs (most of them)
Fix bug with parallel execution and parent folder creation on rename folder upsert folder calls
Remove note id set from local space
Fix bug with hiding items in sidebar (invalid key provided on callback)
Assess some todos
Update storages list data key
Add order ID removal in purge note
Fix sidebar tree ordered IDs handling
Rename realId to orderId