Add Node.js 16 prerequisite to readme and package.json#98
Merged
Komediruzecki merged 1 commit intoBoostIO:masterfrom Apr 5, 2026
Merged
Add Node.js 16 prerequisite to readme and package.json#98Komediruzecki merged 1 commit intoBoostIO:masterfrom
Komediruzecki merged 1 commit intoBoostIO:masterfrom
Conversation
Collaborator
|
Looks good to me, I can check why its not compiling with later nodes, perhaps we can switch to a more recent stable node, there are probably bunch of security issues in currently used packages, but it will depend how dependent are we on that specific node. |
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The program doesn't run with Node 17 or newer. It took me an hour to realize that was why it was not possible to build the project. It runs perfectly in Node 16. So I think it is important to let people know that, to save them time and prevent them from giving up on building the code over such a minor issue.
Ideally, in the future the code could be updated to support the latest Node version. It would probably also be good practice to always specify a recommended Node version for compiling.