Skip to content

Add data points delete confirmation#350

Merged
j-or merged 15 commits intomainfrom
add-data-points-delete-confirmation
Sep 25, 2025
Merged

Add data points delete confirmation#350
j-or merged 15 commits intomainfrom
add-data-points-delete-confirmation

Conversation

@j-or
Copy link
Copy Markdown
Contributor

@j-or j-or commented Sep 24, 2025

No description provided.

@j-or
Copy link
Copy Markdown
Contributor Author

j-or commented Sep 24, 2025

@langdal Jeg kunne ikke dy mig for at bruge 7 min ekstra (cirka...) og tilføje shift + click selection. Det kunne være rigtig fint, hvis du på et tidspunkt lige vil teste og se, om du kan breake noget.

Ting jeg (forhåbentlig) har taget højde for:

  • Man skal stadig kunne "reverse order" på knappen oppe i højre hjørne.
  • Edit og disable knapper skal ikke markere rækken.
  • Selve teksten i tabellen skal ikke blive markeret når man shift + click'er.
  • Man skal stadig kunne copy paste tekst fra tabellen. Ved ikke om nogen gør det men ville være træls at ødelægge.

Edit: Har lige opdaget en bug, hvor en række for meget kan blive slettet. Det ser jeg på.
Edit edit: Copilot fandt så den samme. Den er fixed nu.

@j-or j-or requested review from Copilot and langdal September 24, 2025 12:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds bulk deletion functionality to data points by implementing row selection and multi-delete capabilities. The feature allows users to select multiple rows using click and shift+click interactions, then delete them all at once via a confirmation dialog.

  • Introduces row selection mechanism with visual feedback and keyboard interaction handling
  • Implements bulk deletion capability that replaces individual row deletion
  • Updates the editable table component to support multi-row selection and bulk operations

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
useDataPoints.ts Adds deleteRows function to handle batch deletion of multiple data points
useDataPoints.test.ts Adds test coverage for both single and multi-row deletion scenarios
data-points.tsx Updates to use bulk deletion instead of individual row deletion
editable-table.tsx Implements row selection UI with shift+click support and bulk delete controls
editable-table.style.ts Adds styling for selection states and control buttons
editable-table-row.tsx Updates component interface to support selection functionality
editable-table-collapsed-row.tsx Removes individual delete button and adds row selection click handlers
editable-table-collapsed-row.style.ts Adds visual styling for selected row states
real-bottles-raise.md Documents the feature addition in changelog

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/ui/src/features/core/editable-table/editable-table.tsx Outdated
Comment thread packages/ui/src/features/core/editable-table/editable-table.tsx Outdated
Jack Ord and others added 2 commits September 24, 2025 12:53
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@langdal
Copy link
Copy Markdown
Member

langdal commented Sep 24, 2025

Er det meningen man skal vælge flere rækker blot ved at klikke på dem?
normalt ville man de-selecte den forrige række og kun have valgt den man senest har klikket på.
Multi select kan så aktiveres med ctrl+click?

Jack Ord added 2 commits September 25, 2025 07:03
…tV/process-optimizer-frontend into add-data-points-delete-confirmation
@j-or
Copy link
Copy Markdown
Contributor Author

j-or commented Sep 25, 2025

Er det meningen man skal vælge flere rækker blot ved at klikke på dem? normalt ville man de-selecte den forrige række og kun have valgt den man senest har klikket på. Multi select kan så aktiveres med ctrl+click?

Du har nok ret i at man ville forvente ctrl + click, især efter jeg tilføjede shift + click. Det er ændret nu til ctrl/cmd + click.

@j-or j-or merged commit 8a31de5 into main Sep 25, 2025
1 check passed
@j-or j-or deleted the add-data-points-delete-confirmation branch September 25, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants