Conversation
|
@langdal Jeg kunne ikke dy mig for at bruge 7 min ekstra (cirka...) og tilføje shift + click selection. Det kunne være rigtig fint, hvis du på et tidspunkt lige vil teste og se, om du kan breake noget. Ting jeg (forhåbentlig) har taget højde for:
Edit: Har lige opdaget en bug, hvor en række for meget kan blive slettet. Det ser jeg på. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds bulk deletion functionality to data points by implementing row selection and multi-delete capabilities. The feature allows users to select multiple rows using click and shift+click interactions, then delete them all at once via a confirmation dialog.
- Introduces row selection mechanism with visual feedback and keyboard interaction handling
- Implements bulk deletion capability that replaces individual row deletion
- Updates the editable table component to support multi-row selection and bulk operations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| useDataPoints.ts | Adds deleteRows function to handle batch deletion of multiple data points |
| useDataPoints.test.ts | Adds test coverage for both single and multi-row deletion scenarios |
| data-points.tsx | Updates to use bulk deletion instead of individual row deletion |
| editable-table.tsx | Implements row selection UI with shift+click support and bulk delete controls |
| editable-table.style.ts | Adds styling for selection states and control buttons |
| editable-table-row.tsx | Updates component interface to support selection functionality |
| editable-table-collapsed-row.tsx | Removes individual delete button and adds row selection click handlers |
| editable-table-collapsed-row.style.ts | Adds visual styling for selected row states |
| real-bottles-raise.md | Documents the feature addition in changelog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Er det meningen man skal vælge flere rækker blot ved at klikke på dem? |
…tV/process-optimizer-frontend into add-data-points-delete-confirmation
Du har nok ret i at man ville forvente ctrl + click, især efter jeg tilføjede shift + click. Det er ændret nu til ctrl/cmd + click. |
No description provided.