fix: type WalletStatusVerifier children as ReactNode instead of ReactElement#460
Merged
gabitoesmiapodo merged 1 commit intodevelopfrom Apr 10, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WalletStatusVerifier component’s public props to correctly allow any valid React children, aligning its typing with how the component behaves (a simple context provider/gate). It also cleans up a demo that previously needed a fragment and lint suppression due to the overly strict ReactElement children type.
Changes:
- Updated
WalletStatusVerifierProps.childrenfromReactElementtoReactNode. - Removed an unnecessary fragment wrapper (and related lint suppression) in the
TransactionButtondemo now that multiple children are permitted.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/sharedComponents/WalletStatusVerifier.tsx |
Broadens children prop typing to ReactNode so consumers can pass any valid React children. |
src/components/pageComponents/home/Examples/demos/TransactionButton/index.tsx |
Removes fragment wrapper and biome suppression; renders multiple children directly under WalletStatusVerifier. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gabitoesmiapodo
deleted the
fix/454-wallet-status-verifier-children-type
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #454
The
WalletStatusVerifiercomponent restricted itschildrenprop toReactElement, forcing consumers to wrap multiple children in fragments and suppress lint warnings. Since the component is just a context provider,ReactNodeis the correct type.Changes
childrenprop type fromReactElementtoReactNodeinWalletStatusVerifierPropsbiome-ignorelint suppression in theTransactionButtondemoAcceptance criteria
children?: ReactElementtochildren?: ReactNodeinWalletStatusVerifierPropsReactElementconstraintTest plan
Automated tests
No new tests added. Existing tests in
src/components/sharedComponents/WalletStatusVerifier.test.tsxpass (178/178).pnpm testManual verification
No manual steps required.
Breaking changes
None.
Screenshots
None.
Checklist