Merged
Conversation
Reviewer's Guide by SourceryThis pull request bumps the dockview-core library version and includes several refactorings and enhancements to the core components, including Splitview, Paneview, Gridview, and Dockview. It also updates CSS classes and adds new CSS variables for theming. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- This PR introduces a significant version bump; consider providing a more detailed migration guide or highlighting major changes in the description.
- The diff includes extensive class name changes (e.g., 'horizontal' to 'dv-horizontal'); ensure these changes are thoroughly tested across different themes and configurations.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
126
to
-127
| if (dockview.params.observer === null) { | ||
| dockview.params.observer = new ResizeObserver(observerList => resizeObserverHandle(observerList, dockview)); |
There was a problem hiding this comment.
suggestion (performance): Wrapped the ResizeObserver callback in requestAnimationFrame.
This enhancement should help prevent layout thrashing; verify that performance improvements are observed during window resizes.
Suggested change
| if (dockview.params.observer === null) { | |
| dockview.params.observer = new ResizeObserver(observerList => resizeObserverHandle(observerList, dockview)); | |
| if (dockview.params.observer === null) { | |
| // Wrap the ResizeObserver callback in requestAnimationFrame to help prevent layout thrashing during window resizes. | |
| dockview.params.observer = new ResizeObserver(observerList => requestAnimationFrame(() => resizeObserverHandle(observerList, dockview))); |
| */ | ||
| this.layout(json.width, json.height); | ||
| if (json.maximizedNode) { | ||
| const location = json.maximizedNode.location; |
There was a problem hiding this comment.
suggestion (code-quality): Prefer object destructuring when accessing and using properties. (use-object-destructuring)
Suggested change
| const location = json.maximizedNode.location; | |
| const {location} = json.maximizedNode; |
Explanation
Object destructuring can often remove an unnecessary temporary reference, as well as making your code more succinct.From the Airbnb Javascript Style Guide
| } | ||
| } | ||
|
|
||
| const MINIMUM_DOCKVIEW_GROUP_PANEL_WIDTH = 100; | ||
| const MINIMUM_DOCKVIEW_GROUP_PANEL_HEIGHT = 100; | ||
| class DockviewGroupPanel extends GridviewPanel { | ||
| get minimumWidth() { | ||
| var _a; |
There was a problem hiding this comment.
issue (code-quality): Use const or let instead of var. (avoid-using-var)
Explanation
`const` is preferred as it ensures you cannot reassign references (which can lead to buggy and confusing code). `let` may be used if you need to reassign references - it's preferred to `var` because it is block- rather than function-scoped.From the Airbnb JavaScript Style Guide
| return super.__minimumWidth(); | ||
| } | ||
| get minimumHeight() { | ||
| var _a; |
There was a problem hiding this comment.
issue (code-quality): Use const or let instead of var. (avoid-using-var)
Explanation
`const` is preferred as it ensures you cannot reassign references (which can lead to buggy and confusing code). `let` may be used if you need to reassign references - it's preferred to `var` because it is block- rather than function-scoped.From the Airbnb JavaScript Style Guide
| return super.__minimumHeight(); | ||
| } | ||
| get maximumWidth() { | ||
| var _a; |
There was a problem hiding this comment.
issue (code-quality): Use const or let instead of var. (avoid-using-var)
Explanation
`const` is preferred as it ensures you cannot reassign references (which can lead to buggy and confusing code). `let` may be used if you need to reassign references - it's preferred to `var` because it is block- rather than function-scoped.From the Airbnb JavaScript Style Guide
| return super.__maximumWidth(); | ||
| } | ||
| get maximumHeight() { | ||
| var _a; |
There was a problem hiding this comment.
issue (code-quality): Use const or let instead of var. (avoid-using-var)
Explanation
`const` is preferred as it ensures you cannot reassign references (which can lead to buggy and confusing code). `let` may be used if you need to reassign references - it's preferred to `var` because it is block- rather than function-scoped.From the Airbnb JavaScript Style Guide
| super(parentElement, { | ||
| proportionalLayout: options.proportionalLayout, | ||
| constructor(container, options) { | ||
| var _a; |
There was a problem hiding this comment.
issue (code-quality): Use const or let instead of var. (avoid-using-var)
Explanation
`const` is preferred as it ensures you cannot reassign references (which can lead to buggy and confusing code). `let` may be used if you need to reassign references - it's preferred to `var` because it is block- rather than function-scoped.From the Airbnb JavaScript Style Guide
| @@ -9271,18 +9587,17 @@ class SplitviewComponent extends Resizable { | |||
| return this.panels.find((view) => view.id === id); | |||
| } | |||
| addPanel(options) { | |||
| var _a, _b, _c; | |||
| var _a; | |||
There was a problem hiding this comment.
issue (code-quality): Use const or let instead of var. (avoid-using-var)
Explanation
`const` is preferred as it ensures you cannot reassign references (which can lead to buggy and confusing code). `let` may be used if you need to reassign references - it's preferred to `var` because it is block- rather than function-scoped.From the Airbnb JavaScript Style Guide
| createComponent: this.options.frameworkWrapper.body.createComponent, | ||
| } | ||
| : undefined); | ||
| var _a; |
There was a problem hiding this comment.
issue (code-quality): Use const or let instead of var. (avoid-using-var)
Explanation
`const` is preferred as it ensures you cannot reassign references (which can lead to buggy and confusing code). `let` may be used if you need to reassign references - it's preferred to `var` because it is block- rather than function-scoped.From the Airbnb JavaScript Style Guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump version 9.1.0
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号
Description
fixes #314
Customer Impact
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bump DockView version to 9.1.0. Update the dockview-core.esm.js file to version 3.2.0. Fix several bugs related to splitters, tab focusing, and close buttons. Add support for acceptable events, unhandled drag over events, strict event sequencing, no panels overlay option, setting the visibility and size of groups and panels, setting minimum and maximum dimensions, setting initial dimensions, setting panel and group indices, setting popout URL and theme, and setting the locked state and header visibility of groups.
Bug Fixes:
Enhancements:
Build: