chore(DockView2): adjust the dockview side css style#403
Merged
ArgoZhang merged 3 commits intoBootstrapBlazor:masterfrom Apr 1, 2025
izanhzh:master
Merged
chore(DockView2): adjust the dockview side css style#403ArgoZhang merged 3 commits intoBootstrapBlazor:masterfrom izanhzh:master
ArgoZhang merged 3 commits intoBootstrapBlazor:masterfrom
izanhzh:master
Conversation
|
Thanks for your PR, @izanhzh. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's Guide by SourceryThis pull request adjusts the CSS style for the dockview side panels to improve the alignment and layout of elements within the panels. The changes involve modifying the Updated class diagram for DockView CSS stylesclassDiagram
class bb-dockview {
--bb-dockview-aside-width
}
class bb-dockview-aside {
width: var(--bb-dockview-aside-width)
display: flex
align-items: flex-start
justify-content: start
flex-direction: column
}
class bb-dockview-aside-left {
left: 2px
}
class bb-dockview-aside-right {
right: 0
}
bb-dockview -- bb-dockview-aside: contains
bb-dockview-aside -- bb-dockview-aside-left: contains
bb-dockview-aside -- bb-dockview-aside-right: contains
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @izanhzh - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using CSS variables for the
leftproperty to maintain consistency with other styles.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #402
the effect after adjustment:


Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Chores: