Skip to content

chore(DockView2): adjust the dockview side css style#403

Merged
ArgoZhang merged 3 commits intoBootstrapBlazor:masterfrom
izanhzh:master
Apr 1, 2025
Merged

chore(DockView2): adjust the dockview side css style#403
ArgoZhang merged 3 commits intoBootstrapBlazor:masterfrom
izanhzh:master

Conversation

@izanhzh
Copy link
Copy Markdown
Member

@izanhzh izanhzh commented Apr 1, 2025

Link issues

fixes #402

the effect after adjustment:
image
image

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Chores:

  • Modify the CSS positioning and layout of the DockView aside panel to improve alignment and positioning

@bb-auto
Copy link
Copy Markdown

bb-auto Bot commented Apr 1, 2025

Thanks for your PR, @izanhzh. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 1, 2025

Reviewer's Guide by Sourcery

This pull request adjusts the CSS style for the dockview side panels to improve the alignment and layout of elements within the panels. The changes involve modifying the justify-content and flex-direction properties, as well as adjusting the left property for the left side panel.

Updated class diagram for DockView CSS styles

classDiagram
    class bb-dockview {
      --bb-dockview-aside-width
    }
    class bb-dockview-aside {
      width: var(--bb-dockview-aside-width)
      display: flex
      align-items: flex-start
      justify-content: start
      flex-direction: column
    }
    class bb-dockview-aside-left {
      left: 2px
    }
    class bb-dockview-aside-right {
      right: 0
    }

bb-dockview -- bb-dockview-aside: contains
bb-dockview-aside -- bb-dockview-aside-left: contains
bb-dockview-aside -- bb-dockview-aside-right: contains
Loading

File-Level Changes

Change Details Files
Adjusted the CSS style for the dockview side panels to improve alignment and layout.
  • Modified the justify-content property from center to start to align content to the start of the side panel.
  • Added flex-direction: column to arrange items vertically within the side panel.
  • Adjusted the left property for the left side panel to 2px.
src/components/BootstrapBlazor.DockView/wwwroot/css/dockview-bb.css

Assessment against linked issues

Issue Objective Addressed Explanation
#402 Improve the display of the dockview side when there are multiple collapsed labels.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot requested a review from ArgoZhang April 1, 2025 01:38
@bb-auto bb-auto Bot added the chore label Apr 1, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Apr 1, 2025
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @izanhzh - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using CSS variables for the left property to maintain consistency with other styles.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 28a4404 into BootstrapBlazor:master Apr 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(DockView2): adjust the dockview side css style

2 participants