feat(DefaultTableExport): add EnableAutoFilter property#406
Merged
feat(DefaultTableExport): add EnableAutoFilter property#406
Conversation
|
Thanks for your PR, @densen2014. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's Guide by SourceryThis pull request introduces two new parameters, Sequence diagram for the table export process with new optionssequenceDiagram
participant Client
participant DefaultTableExport
participant TableExportOption
participant MiniExcel
participant MemoryStream
Client->>DefaultTableExport: ExportAsync(items, fileName, excelType, options, cols)
DefaultTableExport->>TableExportOption: Read AutoFilter and EnableAutoWidth
DefaultTableExport->>MiniExcel: SaveAsAsync(stream, value, excelType, configuration)
activate MiniExcel
MiniExcel->>MemoryStream: Write Excel data with AutoFilter and EnableAutoWidth
deactivate MiniExcel
DefaultTableExport->>MemoryStream: stream.Position = 0
DefaultTableExport-->>Client: Return Task<bool>
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @densen2014 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why
AutoFilterandEnableAutoWidthare part ofOpenXmlConfiguration.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ArgoZhang
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #407
依赖主工程 TableExportOptions
dotnetcore/BootstrapBlazor#5845
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge