Skip to content

feat(Markdown): support default Language#411

Merged
ArgoZhang merged 2 commits intomasterfrom
chore-md
Apr 25, 2025
Merged

feat(Markdown): support default Language#411
ArgoZhang merged 2 commits intomasterfrom
chore-md

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Apr 25, 2025

Link issues

fixes #410

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Add support for default language in Markdown component by using the current UI culture when no language is explicitly specified

New Features:

  • Implement automatic language fallback to system UI culture when no language is set for the Markdown component

Enhancements:

  • Improve language handling by providing a default language option

@bb-auto bb-auto Bot added the enhancement New feature or request label Apr 25, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 25, 2025

Reviewer's Guide by Sourcery

This pull request modifies the Markdown component to automatically set the editor's language to the current UI culture if a specific language is not provided. This ensures the editor defaults to the user's preferred language settings.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Set the default language for the Markdown editor to the current UI culture if no language is explicitly provided.
  • Modified the Language property to default to CultureInfo.CurrentUICulture.Name if it's null.
src/components/BootstrapBlazor.Markdown/Components/Markdown/Markdown.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#410 Support the ability to set a default language for the Markdown component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added this to the v9.2.0 milestone Apr 25, 2025
@ArgoZhang ArgoZhang merged commit 8e16ec2 into master Apr 25, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the chore-md branch April 25, 2025 02:15
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a constant for the default language instead of using CultureInfo.CurrentUICulture.Name inline.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Markdown): support default Language

1 participant