Skip to content

fix(Splitting): update style file path#442

Merged
ArgoZhang merged 2 commits intomasterfrom
fix-splitting
May 22, 2025
Merged

fix(Splitting): update style file path#442
ArgoZhang merged 2 commits intomasterfrom
fix-splitting

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented May 22, 2025

Link issues

fixes #441

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Fix the CSS file reference for the Splitting component

Bug Fixes:

  • Update Splitting.razor.js to load splitting.bundle.css instead of splitting-cells.css

Chores:

  • Adjust BootstrapBlazor.Splitting.csproj to include the new CSS asset path

@bb-auto bb-auto Bot added the bug Something isn't working label May 22, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 22, 2025

Reviewer's Guide

This PR updates the Splitting component’s stylesheet reference to point to the consolidated bundle CSS, ensuring the correct style file is loaded.

Sequence diagram for updated CSS loading in Splitting component

sequenceDiagram
    participant Init as "Splitting.razor.js init()"
    participant Browser

    Init->>Browser: addLink("./_content/BootstrapBlazor.Splitting/splitting.bundle.css")
    note over Browser: Loads the new<br/>consolidated stylesheet
Loading

File-Level Changes

Change Details Files
Updated Splitting component style link to use bundled CSS
  • Replaced addLink path from splitting-cells.css to splitting.bundle.css
src/components/BootstrapBlazor.Splitting/Components/Splitting/Splitting.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#441 The Splitting component is missing required CSS styles.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added this to the v9.2.0 milestone May 22, 2025
@ArgoZhang ArgoZhang merged commit c6cc5b4 into master May 22, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the fix-splitting branch May 22, 2025 09:56
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Splitting): missing style

1 participant