feat(Editor): update return type nullable#538
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the ImageUpload API to return a genuinely nullable string and simplifies the JS implementation by passing the File object directly to the .NET stream reference. Sequence diagram for updated image upload interactionsequenceDiagram
participant JS as JavaScript
participant Editor as .NET Editor
JS->>Editor: ImageUpload(name, contentType, size, JSStreamReference(file))
Editor->>Editor: OpenReadStreamAsync(size)
Editor->>Editor: OnFileUpload(file)
Editor-->>JS: string? (nullable result)
Class diagram for updated Editor component ImageUpload methodclassDiagram
class Editor {
+Task<string?> ImageUpload(string name, string contentType, long size, IJSStreamReference stream)
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #537
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Allow ImageUpload to return null and streamline JS stream reference creation in the SummerNote editor component.
Bug Fixes:
Enhancements: