Skip to content

bug(SvgEditor): update iamges path#554

Merged
ArgoZhang merged 2 commits intomasterfrom
refactor-svg
Aug 28, 2025
Merged

bug(SvgEditor): update iamges path#554
ArgoZhang merged 2 commits intomasterfrom
refactor-svg

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Aug 28, 2025

Link issues

fixes #553

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Update imgPath to correct path without trailing slash to ensure editor images load correctly

Copilot AI review requested due to automatic review settings August 28, 2025 03:56
@bb-auto bb-auto Bot added the bug Something isn't working label Aug 28, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Aug 28, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Aug 28, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Corrects the image assets path in the SvgEditor initialization by removing an extra trailing slash and aligns the csproj asset settings accordingly to ensure proper resource loading.

Class diagram for SvgEditor initialization options update

classDiagram
    class SvgEditorOptions {
        canvasName: string
        lang: string
        allowInitialUserOverride: bool
        imgPath: string
        showGrid: bool
        extPath: string
        noDefaultExtensions: bool
    }
    SvgEditorOptions : imgPath updated to "./_content/BootstrapBlazor.SvgEditor/editor/images"
Loading

File-Level Changes

Change Details Files
Fixed image assets path resolution in SvgEditor
  • Removed trailing slash from imgPath in init configuration
  • Updated project file asset include settings to match the updated image path
src/components/BootstrapBlazor.SVGEditor/Components/SvgEditor/SvgEditor.razor.js
src/components/BootstrapBlazor.SVGEditor/BootstrapBlazor.SvgEditor.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#553 Fix the incorrect images path in SvgEditor so that image resources are loaded correctly.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the SvgEditor component by correcting the images path configuration and increments the package version.

  • Removes trailing slash from the imgPath configuration to fix image loading issues
  • Updates package version from 9.0.3 to 9.0.4

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
SvgEditor.razor.js Corrects the imgPath configuration by removing trailing slash
BootstrapBlazor.SvgEditor.csproj Increments version number to 9.0.4

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

lang: "en",
allowInitialUserOverride: false,
imgPath: "./_content/BootstrapBlazor.SvgEditor/editor/images/",
imgPath: "./_content/BootstrapBlazor.SvgEditor/editor/images",
Copy link

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title contains a spelling error: 'iamges' should be 'images'. While this doesn't affect the code functionality, it's worth noting for consistency.

Copilot uses AI. Check for mistakes.
@ArgoZhang ArgoZhang merged commit d0db0be into master Aug 28, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the refactor-svg branch August 28, 2025 03:57
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(SvgEditor): iamges path incorrect

2 participants