Skip to content

feat(FontAwesome): bump version 9.1.1#570

Merged
ArgoZhang merged 2 commits intomasterfrom
feat-fa
Sep 3, 2025
Merged

feat(FontAwesome): bump version 9.1.1#570
ArgoZhang merged 2 commits intomasterfrom
feat-fa

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Sep 3, 2025

Link issues

fixes #569

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bump Font Awesome to 7.0.1 and apply upstream CSS updates including fallback content handling and refined .fa-stack layout

Bug Fixes:

Enhancements:

  • Upgrade Font Awesome Free from version 7.0.0 to 7.0.1
  • Add a @supports block to provide fallback content handling for older browsers
  • Use CSS variables and inset for .fa-stack positioning and sizing

Copilot AI review requested due to automatic review settings September 3, 2025 01:29
@bb-auto bb-auto Bot added the enhancement New feature or request label Sep 3, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Sep 3, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Sep 3, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR bumps the Font Awesome version and updates the CSS implementation to improve browser compatibility for icon rendering and refactors stack icon positioning using CSS variables.

File-Level Changes

Change Details Files
Bumped Font Awesome version metadata
  • Updated version number in the header comment from 7.0.0 to 7.0.1
  • Synchronized header update in both regular and minified CSS
src/components/BootstrapBlazor.FontAwesome/wwwroot/css/all.css
src/components/BootstrapBlazor.FontAwesome/wwwroot/css/all.min.css
Added fallback for content property on older browsers
  • Wrapped icon selectors in an @supports not (content: ""/"") block
  • Restored var(--fa) assignment inside the fallback block to maintain legacy support
src/components/BootstrapBlazor.FontAwesome/wwwroot/css/all.css
Refactored .fa-stack positioning to use CSS variables
  • Introduced --fa-width variable set to 100%
  • Replaced left: 0 with inset: 0 shorthand
  • Changed width from a fixed 100% to var(--fa-width)
src/components/BootstrapBlazor.FontAwesome/wwwroot/css/all.css
Regenerated minified CSS to reflect source changes
  • Rebuilt all.min.css to include header bump and new rules
  • Verified minified output matches updated all.css content
src/components/BootstrapBlazor.FontAwesome/wwwroot/css/all.min.css

Assessment against linked issues

Issue Objective Addressed Explanation
#569 Update FontAwesome package and related files from version 7.0.0 to 7.0.1.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the FontAwesome package from version 7.0.0 to 7.0.1 and bumps the project version to 9.1.1 accordingly. The update includes enhancements to CSS compatibility with browser support for the content property syntax and improvements to the stacking functionality.

  • Updates FontAwesome Free version from 7.0.0 to 7.0.1 in CSS files
  • Adds backward compatibility support for older browsers in CSS content property usage
  • Improves FA stacking component positioning and width handling

Reviewed Changes

Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.

File Description
all.min.css Minified CSS updated with new FontAwesome version and feature improvements
all.css Unminified CSS with version update and new browser compatibility features
BootstrapBlazor.FontAwesome.csproj Project version bumped to 9.1.1 to reflect FontAwesome update

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ArgoZhang ArgoZhang merged commit b7efad3 into master Sep 3, 2025
1 check passed
@ArgoZhang ArgoZhang deleted the feat-fa branch September 3, 2025 01:30
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(FontAwesome): bump version 9.1.1

2 participants