Skip to content

feat(MeiliSearch): update css#586

Merged
ArgoZhang merged 5 commits intomasterfrom
refactor-search
Oct 10, 2025
Merged

feat(MeiliSearch): update css#586
ArgoZhang merged 5 commits intomasterfrom
refactor-search

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Oct 10, 2025

Link issues

fixes #585

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update the MeiliSearch component CSS to introduce a configurable input color, remove redundant font-size rules, and adopt logical margin properties for improved theming and layout.

Enhancements:

  • Introduce a --bb-global-search-input-color CSS variable for the search input and placeholder text
  • Replace hard-coded rgba color values with the new CSS variable
  • Remove explicit font-size declarations from search dialog icons and clear buttons
  • Convert static margin-top and margin-bottom properties to logical margin-block-start and margin-block-end for vertical spacing

Copilot AI review requested due to automatic review settings October 10, 2025 03:16
@bb-auto bb-auto Bot added the enhancement New feature or request label Oct 10, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Oct 10, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Oct 10, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update MeiliSearch CSS to introduce a new input color variable, switch to logical margin properties for RTL support, and remove hardcoded icon font sizes.

Class diagram for CSS variable and selector changes in MeiliSearch

classDiagram
    class bb-g-search {
        +--bb-global-search-padding
        +--bb-global-search-width
        +--bb-global-search-input-color (added)
        color (changed: now uses input color variable)
    }
    class search-dialog-icon {
        cursor
        margin-inline-end
        font-size (removed)
    }
    class search-dialog-input__search-dialog-clear {
        cursor
        font-size (removed)
    }
    class search-dialog-menu__search-dialog-menu-item {
        margin-block-end (changed from margin-bottom)
    }
    class search-dialog-list__search-dialog-item {
        margin-block-start (changed from margin-top)
    }
    class search-dialog-list__search-dialog-item__search-dialog-item-sub {
        margin-block-start (changed from margin-top)
    }
    class search-dialog-list__search-dialog-item__li {
        margin-block-start (changed from margin-top)
    }
Loading

File-Level Changes

Change Details Files
Define and apply a new input color variable for global search
  • Add --bb-global-search-input-color variable
  • Replace direct rgba color assignments with the new variable
  • Update placeholder color to use the new variable
src/components/BootstrapBlazor.MeiliSearch/wwwroot/meilisearch.css
Switch to logical margin properties for better layout consistency
  • Replace margin-bottom with margin-block-end
  • Replace margin-top with margin-block-start
src/components/BootstrapBlazor.MeiliSearch/wwwroot/meilisearch.css
Remove hardcoded font sizes on search icons
  • Remove font-size: 18px from .search-dialog-icon
  • Remove font-size: 18px from .search-dialog-clear
src/components/BootstrapBlazor.MeiliSearch/wwwroot/meilisearch.css

Assessment against linked issues

Issue Objective Addressed Explanation
#585 Update the CSS for the MeiliSearch component.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CSS styling for the MeiliSearch component to improve maintainability and use modern CSS properties. The main focus is on consolidating color definitions into CSS custom properties and replacing directional margin properties with logical equivalents.

  • Introduces a CSS custom property for consistent color management across search input elements
  • Replaces directional margin properties (margin-top, margin-bottom) with logical properties (margin-block-start, margin-block-end)
  • Removes hardcoded font-size values from icon elements and updates package version

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/components/BootstrapBlazor.MeiliSearch/wwwroot/meilisearch.css Updates CSS with custom properties for colors, logical margin properties, and removes hardcoded font sizes
src/components/BootstrapBlazor.MeiliSearch/BootstrapBlazor.MeiliSearch.csproj Updates project version and BootstrapBlazor package dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ArgoZhang ArgoZhang merged commit 1e4a013 into master Oct 10, 2025
1 of 2 checks passed
@ArgoZhang ArgoZhang deleted the refactor-search branch October 10, 2025 03:16
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(MeiliSearch): update css

2 participants