Skip to content

feat(OctIcon): bump version 9.0.7#643

Merged
ArgoZhang merged 3 commits intomasterfrom
feat-icon
Nov 6, 2025
Merged

feat(OctIcon): bump version 9.0.7#643
ArgoZhang merged 3 commits intomasterfrom
feat-icon

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Nov 6, 2025

Link issues

fixes #642

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bump OctIcon component to version 9.0.7, update SVG assets, and address issue #642

Bug Fixes:

Enhancements:

  • Bump OctIcon component to version 9.0.7
  • Update octicon.svg assets to the latest version

Copilot AI review requested due to automatic review settings November 6, 2025 02:29
@bb-auto bb-auto Bot added the chore label Nov 6, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Nov 6, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Nov 6, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 00a4479 into master Nov 6, 2025
5 of 6 checks passed
@ArgoZhang ArgoZhang deleted the feat-icon branch November 6, 2025 02:29
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new inbox-fill-16 icon to the OctIcon component library and introduces conditional versioning based on Visual Studio version to support different framework versions.

  • Adds the inbox-fill-16 icon SVG symbol to the icon library
  • Implements conditional versioning for Visual Studio 17.0 (version 9.0.7) and VS 18.0 (version 10.0.0-rc.2.1.0)
  • Configures conditional package references for BootstrapBlazor dependency based on Visual Studio version

Reviewed Changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 2 comments.

File Description
octicon.svg Adds new inbox-fill-16 icon symbol for filled inbox variant
BootstrapBlazor.OctIcon.csproj Introduces VS version-based conditional versioning and package references

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


<ItemGroup>
<ItemGroup Condition="'$(VisualStudioVersion)' == '17.0'">
<PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" />
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BootstrapBlazor package reference for VS 17.0 uses $(BBVersion) variable which is not defined in this project file, while VS 18.0 uses a hardcoded version. This inconsistency could cause build issues. Based on other similar projects (e.g., BootstrapBlazor.Region uses '9.12.0', BootstrapBlazor.Html2Pdf uses '9.12.0'), consider either defining the BBVersion property or using a specific version like the other files in the codebase.

Suggested change
<PackageReference Include="BootstrapBlazor" Version="$(BBVersion)" />
<PackageReference Include="BootstrapBlazor" Version="9.12.0" />

Copilot uses AI. Check for mistakes.
Comment on lines +7 to 9
<PropertyGroup Condition="'$(VisualStudioVersion)' == '18.0'">
<Version>10.0.0-rc.2.1.0</Version>
</PropertyGroup>
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The conditional versioning approach based on VisualStudioVersion property is inconsistent with the BootstrapBlazor.Topology.csproj file in the same repository, which uses a single unconditional ItemGroup for the BootstrapBlazor package reference. Consider whether this conditional approach is necessary for this specific component or if it should follow the simpler pattern used in Topology.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(OctIcon): bump version 9.0.7

2 participants