Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR upgrades Bunit to v2.0 by adapting test projects to the new BunitContext API, replacing deprecated rendering methods, and applying related test adjustments. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the bunit testing library from version 1.x to 2.0, updating the test infrastructure and fixing a test assertion bug that was uncovered during the migration.
- Updates bunit dependency to version 2.*
- Migrates all test code to use bunit 2.0 API
- Fixes incorrect test assertion for Beijing municipality cities
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/UnitTestEditor/BootstrapBlazorTestBase.cs | Updated copyright header and migrated from TestContext to BunitContext for bunit 2.0 compatibility |
| test/UnitTestEditor/EditorTest.cs | Updated copyright header and migrated from RenderComponent to Render and SetParametersAndRender to Render for bunit 2.0 API |
| test/UnitTestRegion/ServiceTest.cs | Updated copyright header and fixed test assertion from Assert.Empty to Assert.Single for Beijing cities (correct behavior for municipality) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #702
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Migrate unit tests to bUnit v2 API, update test expectations, refresh file headers, and bump the project version to 2.0.
Enhancements:
Tests:
Chores: