Skip to content

feat(PdfReader): add ShowToolbar parameter#741

Merged
ArgoZhang merged 2 commits intomasterfrom
dev-response
Nov 28, 2025
Merged

feat(PdfReader): add ShowToolbar parameter#741
ArgoZhang merged 2 commits intomasterfrom
dev-response

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Nov 28, 2025

Link issues

fixes #740

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Adjust PdfReader toolbar rendering and styling when the toolbar is hidden.

Enhancements:

  • Render the PdfReader toolbar container consistently while conditionally displaying its contents based on the ShowToolbar parameter.
  • Set a CSS custom property to collapse the toolbar height when ShowToolbar is false to maintain proper layout behavior.

Copilot AI review requested due to automatic review settings November 28, 2025 00:59
@bb-auto bb-auto Bot added the enhancement New feature or request label Nov 28, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Nov 28, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Nov 28, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts PdfReader toolbar rendering so the toolbar container is always present while allowing it to be visually hidden via a new CSS variable when ShowToolbar is false, improving layout consistency and enabling external styling based on toolbar visibility.

Class diagram for updated PdfReader toolbar and style handling

classDiagram
    class PdfReader {
        bool ShowToolbar
        bool EnableThumbnails
        string ViewHeight
        string StyleString
    }

    class CssBuilder {
        CssBuilder Default()
        CssBuilder AddClass(string value, bool when)
        CssBuilder AddClassFromAttributes(object additionalAttributes)
        string Build()
    }

    PdfReader ..> CssBuilder : builds StyleString
Loading

Flow diagram for PdfReader toolbar rendering and CSS variable logic

flowchart TD
    Start[Start render PdfReader] --> CheckShowToolbar{ShowToolbar?}
    CheckShowToolbar -->|true| RenderToolbarContent[Render content inside div.bb-view-toolbar]
    CheckShowToolbar -->|false| SkipToolbarContent[Render empty div.bb-view-toolbar]

    Start --> BuildStyleString[Build StyleString with CssBuilder]
    BuildStyleString --> CheckShowToolbarStyle{ShowToolbar?}
    CheckShowToolbarStyle -->|true| NoToolbarHeightVar[Do not add --bb-pdf-toolbar-height]
    CheckShowToolbarStyle -->|false| AddToolbarHeightVar[Add CSS variable --bb-pdf-toolbar-height: 0;]

    RenderToolbarContent --> RenderMain[Render main PDF area]
    SkipToolbarContent --> RenderMain

    NoToolbarHeightVar --> RenderMain
    AddToolbarHeightVar --> RenderMain

    RenderMain --> End[Finish render PdfReader]
Loading

File-Level Changes

Change Details Files
Always render the toolbar container but conditionally render its content based on ShowToolbar.
  • Move the ShowToolbar conditional check inside the toolbar container div instead of wrapping the entire toolbar block.
  • Ensure the bb-view-toolbar wrapper div is always in the DOM to maintain consistent structure and layout with or without the toolbar content.
src/components/BootstrapBlazor.PdfReader/PdfReader.razor
Expose toolbar visibility to styles via a CSS variable derived from ShowToolbar.
  • Extend StyleString construction to include a --bb-pdf-toolbar-height CSS custom property when ShowToolbar is false, setting it to 0.
  • Retain existing style composition using CssBuilder while augmenting it with the new conditional variable.
src/components/BootstrapBlazor.PdfReader/PdfReader.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#740 Add (and wire up) a ShowToolbar parameter to the PdfReader component so that the toolbar can be conditionally shown/hidden without leaving layout space when hidden.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 7223519 into master Nov 28, 2025
5 of 6 checks passed
@ArgoZhang ArgoZhang deleted the dev-response branch November 28, 2025 01:00
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements the ability to hide the toolbar in the PdfReader component by enhancing the existing ShowToolbar parameter. The feature allows users to toggle the visibility of the entire toolbar while maintaining proper layout calculations through CSS variables.

Key changes:

  • Modified toolbar rendering to use CSS height control instead of conditional element rendering
  • Set --bb-pdf-toolbar-height CSS variable to 0 when toolbar is hidden to adjust container height calculations
  • Bumped version to 10.0.4-beta02

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
PdfReader.razor Restructured toolbar div to always render with conditional content, enabling CSS-based height control
PdfReader.razor.cs Added CSS variable override to set toolbar height to 0 when ShowToolbar is false
BootstrapBlazor.PdfReader.csproj Version bump from 10.0.4-beta01 to 10.0.4-beta02

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(PdfReader): add ShowToolbar parameter

2 participants