Skip to content

chore(Props): update BBVersion to 10.0.0#766

Merged
ArgoZhang merged 1 commit intomasterfrom
chore-config
Dec 1, 2025
Merged

chore(Props): update BBVersion to 10.0.0#766
ArgoZhang merged 1 commit intomasterfrom
chore-config

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 1, 2025

Link issues

fixes #765

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Chores:

  • Update shared build properties to reference BBVersion 10.0.0.

Copilot AI review requested due to automatic review settings December 1, 2025 08:25
@bb-auto bb-auto Bot added the chore label Dec 1, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Dec 1, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Dec 1, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 4bba8cd into master Dec 1, 2025
3 of 4 checks passed
@ArgoZhang ArgoZhang deleted the chore-config branch December 1, 2025 08:25
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the BBVersion property from a wildcard pattern (10.*) to a fixed version (10.0.0) in the build configuration file, addressing issue #765. This change affects all extension projects that reference the BootstrapBlazor package through the BBVersion variable.

Key Changes:

  • Changed BBVersion from wildcard 10.* to specific version 10.0.0
  • Reorganized PropertyGroup structure (moved BBVersion to its own PropertyGroup)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Directory.Build.props

<PropertyGroup>
<BBVersion>10.*</BBVersion>
<BBVersion>10.0.0</BBVersion>
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from 10.* to 10.0.0 creates an inconsistency with other version properties in this file. Lines 29-33 use wildcard patterns (6.0.*, 7.0.*, etc.) for .NET versions, which allows automatic patch version updates. Pinning BBVersion to a specific version (10.0.0) means it will need manual updates for every patch release, while the .NET versions will update automatically. Consider whether this intentional difference is necessary, or if 10.* should be retained for consistency.

Suggested change
<BBVersion>10.0.0</BBVersion>
<BBVersion>10.*</BBVersion>

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Props): update BBVersion to 10.0.0

2 participants