Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
This PR updates the BBVersion property from a wildcard pattern (10.*) to a fixed version (10.0.0) in the build configuration file, addressing issue #765. This change affects all extension projects that reference the BootstrapBlazor package through the BBVersion variable.
Key Changes:
- Changed BBVersion from wildcard
10.*to specific version10.0.0 - Reorganized PropertyGroup structure (moved BBVersion to its own PropertyGroup)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <PropertyGroup> | ||
| <BBVersion>10.*</BBVersion> | ||
| <BBVersion>10.0.0</BBVersion> |
There was a problem hiding this comment.
The change from 10.* to 10.0.0 creates an inconsistency with other version properties in this file. Lines 29-33 use wildcard patterns (6.0.*, 7.0.*, etc.) for .NET versions, which allows automatic patch version updates. Pinning BBVersion to a specific version (10.0.0) means it will need manual updates for every patch release, while the .NET versions will update automatically. Consider whether this intentional difference is necessary, or if 10.* should be retained for consistency.
| <BBVersion>10.0.0</BBVersion> | |
| <BBVersion>10.*</BBVersion> |
Link issues
fixes #765
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Chores: