Skip to content

feat(HikVision): add szBasePath parameter#793

Merged
ArgoZhang merged 2 commits intomasterfrom
fix-hik
Dec 6, 2025
Merged

feat(HikVision): add szBasePath parameter#793
ArgoZhang merged 2 commits intomasterfrom
fix-hik

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 6, 2025

Link issues

fixes #792

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

New Features:

  • Specify szBasePath for the HikVision WebVideoCtrl plugin to load resources from the BootstrapBlazor.HikVision content directory.

Copilot AI review requested due to automatic review settings December 6, 2025 03:35
@bb-auto bb-auto Bot added the enhancement New feature or request label Dec 6, 2025
@bb-auto bb-auto Bot added this to the v9.2.0 milestone Dec 6, 2025
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Dec 6, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds explicit szBasePath configuration when initializing the HikVision WebVideoCtrl plugin so its static resources are loaded from the BootstrapBlazor.HikVision content path.

Sequence diagram for HikVision WebVideoCtrl initialization with szBasePath

sequenceDiagram
    participant Browser
    participant HikvisionJs as hikvision_js
    participant WebVideoCtrl
    participant StaticContent as BootstrapBlazor_HikVision_Content

    Browser->>HikvisionJs: init(id)
    HikvisionJs->>WebVideoCtrl: I_InitPlugin({ szBasePath: ./_content/BootstrapBlazor.HikVision, bWndFull: true, iWndowType: 1, cbSelWnd })
    WebVideoCtrl->>StaticContent: Load plugin assets from szBasePath
    StaticContent-->>WebVideoCtrl: Return JS/CSS/plugin files
    WebVideoCtrl-->>HikvisionJs: Initialization result
    HikvisionJs-->>Browser: { inited, iWndIndex }
Loading

File-Level Changes

Change Details Files
Configure HikVision WebVideoCtrl plugin to use the component library’s static content base path.
  • Extend plugin initialization options to include szBasePath pointing at the _content/BootstrapBlazor.HikVision folder so resources resolve correctly in Blazor environments
  • Keep existing window configuration (full window, single-window type, selection callback) unchanged aside from the new base path setting
src/components/BootstrapBlazor.HikVision/wwwroot/hikvision.js

Assessment against linked issues

Issue Objective Addressed Explanation
#792 Add the szBasePath parameter to the HikVision WebVideoCtrl.I_InitPlugin initialization so that the plugin uses the correct base path.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit ee340ab into master Dec 6, 2025
3 of 4 checks passed
@ArgoZhang ArgoZhang deleted the fix-hik branch December 6, 2025 03:35
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider avoiding the hard-coded ./_content/BootstrapBlazor.HikVision string by deriving the base path from the hosting environment (e.g., using a configuration value or a helper that knows the static web assets base path) so the plugin works reliably under different deployment setups or virtual directories.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider avoiding the hard-coded `./_content/BootstrapBlazor.HikVision` string by deriving the base path from the hosting environment (e.g., using a configuration value or a helper that knows the static web assets base path) so the plugin works reliably under different deployment setups or virtual directories.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the szBasePath parameter to the HikVision component's initialization configuration to specify the base path for the plugin's static resources. The version is bumped from beta04 to beta05 to reflect this enhancement.

  • Adds szBasePath parameter to WebVideoCtrl.I_InitPlugin configuration
  • Updates package version to 10.0.0-beta05

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/components/BootstrapBlazor.HikVision/wwwroot/hikvision.js Adds szBasePath parameter to plugin initialization to specify the static content path
src/components/BootstrapBlazor.HikVision/BootstrapBlazor.HikVision.csproj Increments version from 10.0.0-beta04 to 10.0.0-beta05

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(HikVision): add szBasePath parameter

2 participants