Fix lint automation workflow failing when no lint errors are found#34
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: BorDevTech <73800053+BorDevTech@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Failing when no lint errors
Fix lint automation workflow failing when no lint errors are found
Sep 21, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical issue in the lint automation workflow where builds were incorrectly failing even when no lint errors were present. The workflow was setting has-issues=true whenever the lint report file existed, regardless of the actual issue count.
Key changes:
- Modified workflow logic to check the actual issue count before setting the
has-issuesflag - Added conditional logic to properly set
has-issues=falsewhen there are 0 lint issues - Improved feedback messages to clearly indicate when no issues are found
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lint automation workflow was incorrectly failing builds even when no lint errors were present. The issue was in the workflow logic that determines whether lint issues exist.
Problem
The workflow step "🔍 Run lint analysis" was setting
has-issues=truewhenever thelint-analysis-report.jsonfile existed, regardless of the actual issue count. Since the lint analyzer always creates this report file (even when there are 0 issues), this caused the workflow to incorrectly think there were lint problems and trigger the "❌ Fail build on lint errors" step.Root Cause
In
.github/workflows/lint-automation.yml, the logic was:This meant that
has-issueswas set totruewhenever the report file existed, even whentotalIssueswas 0.Solution
Modified the workflow to check the actual issue count before setting the
has-issuesflag:Now the workflow correctly:
has-issues=falsewhen there are 0 lint issueshas-issues=trueonly when there are actual lint issuesFixes #33.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.