Skip to content

Bioc review2#8

Merged
ncborcherding merged 4 commits into
mainfrom
bioc-review2
May 20, 2026
Merged

Bioc review2#8
ncborcherding merged 4 commits into
mainfrom
bioc-review2

Conversation

@ncborcherding
Copy link
Copy Markdown
Member

Per comments raised in Bioconductor/Contributions#4143

  • Vignette: removed undefined variable references (mouse_tcr_data, contig_list placeholder, ... in custom_ref). Five previously unevaluated chunks now run during build, using tempdir(), scRepertoire::contig_list, the bundled gliph_sce, and a real reference data frame built from gliph_input_data. The three remaining eval = FALSE chunks are limited to BiocManager::install() calls and the optional getGLIPHreference() network download.
  • Consolidated duplicated column-type coercion for loops in loadGLIPH(), plotNetwork() and clusterScoring() into a single lapply()-based helper, .coerce_numeric_cols().

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
R/loadGLIPH.R 33.33% 2 Missing ⚠️
Files with missing lines Coverage Δ
R/clusterScoring.R 83.66% <100.00%> (-0.17%) ⬇️
R/plotNetwork.R 46.23% <100.00%> (-0.14%) ⬇️
R/utils-output.R 100.00% <100.00%> (ø)
R/loadGLIPH.R 57.96% <33.33%> (+0.46%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

remove ubuntu devel from automated
@ncborcherding ncborcherding merged commit 17636de into main May 20, 2026
5 checks passed
@ncborcherding ncborcherding deleted the bioc-review2 branch May 20, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant