Add new eslint rules

[kandula-aswin]

Introduce new ESLint rules

• vars-on-top
• require-jsdoc

vars-on-top gets a minor thumbs down from me due to this sort of thing:

function AConstructor() {

  // a load of stuff

  // 500-1000 lines of code loads

}

var obj = new AConstructor();
// then more stuff with obj

When hoisting vars we end up with either calling AConstructor() before it is defined or needlessly separating the declaration from the use of var obj. Not the end of the world but what's the point?

Happy to require jsdoc so long as it is not me that has to retro-fit all the missing doc from 13-odd years of code.

[ricksbrown]

I vote for: "vars-on-top": "warn"

[ricksbrown]

To answer @marksreeves question about what the point may be, perhaps it is worth it not for those cases (I agree they are pointless) but enabling this rule (even to "warn" level) would capture other cases that do make more sense.

While manual hoisting is largely stylistic there are some cases where it can save us from mistakes.