QC165120 encoded url components are being decoded #1211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry @ricksbrown I am closing this PR and re-doing it. Code change is good but test utility wasn't updated and you aren't available to grab your branch. It won't take long. |
ghost
closed this
ghost
mentioned this pull request
Merged
ghost
pushed a commit
that referenced
this pull request
May 24, 2017
* Revert URL percent encoding See PR #1211: > This is basically reverting to previous behaviour. This needs to be thought out in detail before we start messing with URLs. There is one unit test, my hunch is it needs at least 10 to cover the various permutations. > Before this change this `http://www.example.com/&foo=fu%2Fbar` would be rendered as this `http://www.example.com/&foo=fu/bar` and that's not right at all. > My gut feeling is that URL encoding (all or part of the URL) is the responsibility of the application developer. If we give it some thought maybe there is a way.... I guess if there's a space in the URL it hasn't been encoded (but maybe part of it has?) * changelog
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically reverting to previous behaviour.
This needs to be thought out in detail before we start messing with URLs.
There is one unit test, my hunch is it needs at least 10 to cover the various permutations.
Before this change this
http://www.example.com/&foo=fu%2Fbarwould be rendered as thishttp://www.example.com/&foo=fu/barand that's not right at all.My gut feeling is that URL encoding (all or part of the URL) is the responsibility of the application developer. If we give it some thought maybe there is a way.... I guess if there's a space in the URL it hasn't been encoded (but maybe part of it has?)