Skip to content

QC165120 encoded url components are being decoded #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

QC165120 encoded url components are being decoded #1211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions wcomponents-core/src/main/java/com/github/bordertech/wcomponents/XmlStringBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,13 +207,7 @@ private void indent() {
* @param value the URL value of the attribute to be added.
*/
public void appendUrlAttribute(final String name, final String value) {
write(' ');
write(name);
write("=\"");
if (value != null) {
write(WebUtilities.encodeUrl(value));
}
write('"');
appendAttribute(name, value);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion ...examples/src/main/java/com/github/bordertech/wcomponents/examples/LinkOptionsExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public class LinkOptionsExample extends WPanel {
/**
* link URL.
*/
private static final String URL = "http://www.example.com";
private static final String URL = "http://www.example.com/&foo=fu%2Fbar";

private final WTextField tfUrlField = new WTextField();

Expand Down