Update Eslint#1672
Merged
ricksbrown merged 5 commits intoBorderTech:georgiefrom Oct 2, 2019
ricksbrown:post-ant
Merged
Conversation
Yep, I also threw in a completely unrelated change in, ariaAnalaog should indeed set tabindex when there is a touchscreen.
Also a few other tweaks: - shed methods no longer driven off `actions` map, the methods are simply named what they are named regardless of action names. - wired up a few components to shed events more just to prove it. label, dialog and dialogFrame
This was actually HUGE and that's why it wasn't done earlier. It had to happen because: - We were over three major versions behind 3.19.0 > 6.4.0 - Github was telling us "We found a potential security vulnerability in one of your dependencies." which was ESLint Unfortunately ESLint seems to have changed its mind on a lot of things in the meantime resulting in a LOT of refactoring with 18386 issues. I let ESLint auto fix the test code but attended to the main codebase myself. I considered using Prettier instead but while it may produce consistent results formatting involves a degree of artistic comprehension. I haven't ruled out using Prettier in future. Will consider further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.