Fix several UI bug when displaying data with negative numbers#79
Fix several UI bug when displaying data with negative numbers#79Boris-Em merged 7 commits intoBoris-Em:masterfrom
Conversation
ben181231
commented
Oct 7, 2014
ben181231
commented
- Fix the method calculating max value of the data
- Fix the Y Axis Label Offset when displaying nagative numbers
- Fix the Pop Up Report when displaying nagative numbers
- Fix the method calculating max value of the data - Fix the Y Axis Label Offset when displaying nagative numbers - Fix the Pop Up Report when displaying nagative numbers
|
Thank you for your contribution @ben181231. I haven't find much time to work on BEMSimpleLineGraph lately, but as soon as I do so, I'll be taking a look at your PR and hopefully merge it! |
# Please enter the commit message for your changes. Lines starting # with '#' will be kept; you may remove them yourself if you want to. # An empty message aborts the commit. # On branch master # Your branch is up-to-date with 'origin/master'. # # Changes to be committed: # modified: Classes/BEMSimpleLineGraphView.m #
|
@ben181231 Thanks for your pull-request. I started to doing same fixes, before Iooked at your pull-request. But, what's wrong with Travis build? It's seem that you broke something in this pull-request. |
|
I just had a look on the fails on travis. Seems like the travis was updated to support new Xcode and new SDKs. However, the xctool is not yet supporting that. |
|
Got it. yes, it's not your fault. Look at pull-request #84 and feel free to use it! |
update travis script to avoid "exited with 134"
There was a problem hiding this comment.
Looks good.
Although, should be set to YES in the sample project.
The comment should state that the label will be at the bottom of the graph and not on the side.
Fix several UI bug when displaying data with negative numbers
|
Thank you so much for your valuable contribution @ben181231 (and @skywinder). I will take care of the note that I added. |
4 participants
