Skip to content
This repository was archived by the owner on Dec 2, 2020. It is now read-only.

Update example project#92

Closed
skywinder wants to merge 9 commits intoBoris-Em:masterfrom
skywinder:example-update
Closed

Update example project#92
skywinder wants to merge 9 commits intoBoris-Em:masterfrom
skywinder:example-update

Conversation

@skywinder
Copy link
Copy Markdown
Contributor

Add ability to change animation style from the project.
screen shot 2014-11-05 at 10 27 59

@skywinder skywinder mentioned this pull request Nov 5, 2014
@Boris-Em
Copy link
Copy Markdown
Owner

Boris-Em commented Nov 9, 2014

Hi @skywinder, thank you so much for your work on BEMSimpleLineGraph!
This PR looks good overall.
I just have a quick question though, why is BEMDefaultAnimationTime publicly declared (in BEMSimpleLineGraphView.h instead of the .m)?
Also, I think that it would be better if in the sample project, Bezier curves would be used when the app is launched for the first time.

@skywinder
Copy link
Copy Markdown
Contributor Author

@Boris-Em Yes, both remarks are reasonable. Fixed!

@skywinder
Copy link
Copy Markdown
Contributor Author

Also I fix names in segment control in last 2 commits.

@Sam-Spencer
Copy link
Copy Markdown
Collaborator

Commit 20d9253 lays the groundwork for future customizations of the graph directly from the sample project. Although the feature is not fully implemented yet, this is the direction we are headed (rather than cluttering the Refresh Settings area).

Additionally, commit 9b5b787 adds IBDesignable capabilities to BEMSimpleLineGraph. Now you can alter the appearance of the graph directly from Interface Builder.

Thank you for the Pull Request!

@skywinder
Copy link
Copy Markdown
Contributor Author

It seems, that this PR is not pertinent anymore. Thanks for your improvements! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants