Argument 2 must be passed with the 'ref' keyword

[PCAssistSoftware]

Line 308 of RemoteDesktopControl.xaml.cs

Get

Argument 2 must be passed with the 'ref' keyword
Argument 3 must be passed with the 'ref' keyword

This is with a fresh download from master branch when trying to build/run the code?

[BornToBeRoot]

Which version of VS/.NET/Windows are you using?

Is the pre-build script executed correctly in vs? There is an issue with the SendKeys in MSTSClib which is fixed with these commands:

NETworkManager/Scripts/PreBuildEventCommandLine.ps1

Line 53 in b0c66fd

# Modify MSTSCLib.ddl to fix an issue with SendKeys (See: https://social.msdn.microsoft.com/Forums/windowsdesktop/en-US/9095625c-4361-4e0b-bfcf-be15550b60a8/imsrdpclientnonscriptablesendkeys?forum=windowsgeneraldevelopmentissues&prof=required)

Or just copy the MSTSCLib.dll and AxMSTSCLib.dll from my latest release in the Debug folder...

This is the line with the issue:

NETworkManager/Source/NETworkManager/Controls/RemoteDesktopControl.xaml.cs

Line 308 in b0c66fd

ocx.SendKeys(info.KeyData.Length, info.ArrayKeyUp, info.KeyData);

[PCAssistSoftware]

VS 2019 / Windows 10 / .NET 4.7.2

Actually no the pre-build script didn't allow me to build, so I removed it, not knowing it was related, will add it back tomorrow and let you know exactly why it fails to build with the script enabled

[PCAssistSoftware]

It has nothing to do with the script as that is a build event and I can't get as far as building because of the error in the code as per original report - have attached screenshot this time which hopefully makes it clearer.

[BornToBeRoot]

Can you delete the bin and obj folder and rebuild the solution with the working .ps1 pre build script.

These commands need to be executed to modify the MSTSCLib.dll to allow the additional arguments (pbArrayKeyUp and plKeyData) in the function SendKeys:

NETworkManager/Scripts/PreBuildEventCommandLine.ps1

Lines 53 to 71 in b0c66fd

	# Modify MSTSCLib.ddl to fix an issue with SendKeys (See: https://social.msdn.microsoft.com/Forums/windowsdesktop/en-US/9095625c-4361-4e0b-bfcf-be15550b60a8/imsrdpclientnonscriptablesendkeys?forum=windowsgeneraldevelopmentissues&prof=required)
	Write-Host "Modify MSTSCLib.dll..."
	Write-Host "Using ildasm.exe from: $IldasmPath"
	$MSTSCLibDLLPath = "$OutPath\MSTSCLib.dll"
	$MSTSCLibILPath = "$OutPath\MSTSCLib.il"
	Start-Process -FilePath $IldasmPath -ArgumentList "$MSTSCLibDLLPath /out=$MSTSCLibILPath" -Wait -NoNewWindow
	Write-Host "Replace ""[in] bool& pbArrayKeyUp"" with ""[in] bool[] marshal([+0]) pbArrayKeyUp"""
	(Get-Content -Path $MSTSCLibILPath).Replace("[in] bool& pbArrayKeyUp", "[in] bool[] marshal([+0]) pbArrayKeyUp") | Set-Content -Path $MSTSCLibILPath
	Write-Host "Replace ""[in] int32& plKeyData"" with ""[in] int32[] marshal([+0]) plKeyData"""
	(Get-Content -Path $MSTSCLibILPath).Replace("[in] int32& plKeyData", "[in] int32[] marshal([+0]) plKeyData") | Set-Content -Path $MSTSCLibILPath
	Start-Process -FilePath $IlasmPath -ArgumentList "/dll $MSTSCLibILPath /output:$MSTSCLibDllPath" -Wait -NoNewWindow
	Remove-Item -Path "$MSTSCLibILPath"
	Remove-Item -Path "$OutPath\MSTSCLib.res"

The pre build script does:

1. Build MSTSCLib.dll and AxMSTSCLib.dll with aximp.exe from \system32\mstscax.dll
2. Decompile (ildasm.exe), Modify and Compoile (ilasm.exe) the MSTSCLib.dll to use the SendKeys function (IMsRdpClientNonScriptable::SendKeys)

[PCAssistSoftware]

Deleting bin and obj and then rebuilding seems to have resolved the problem - thank you very much :)

[BornToBeRoot]

Great!