Skip to content

fix: the crsf receiver packet handler copies rf-rece... in crsf.c#132

Merged
bkleiner merged 1 commit into
BossHobby:developfrom
orbisai0security:fix-crsf-buffer-overflow-v001
May 12, 2026
Merged

fix: the crsf receiver packet handler copies rf-rece... in crsf.c#132
bkleiner merged 1 commit into
BossHobby:developfrom
orbisai0security:fix-crsf-buffer-overflow-v001

Conversation

@orbisai0security
Copy link
Copy Markdown
Contributor

Summary

Fix critical severity security issue in src/rx/crsf.c.

Vulnerability

Field Value
ID V-001
Severity CRITICAL
Scanner multi_agent_ai
Rule V-001
File src/rx/crsf.c:91

Description: The CRSF receiver packet handler copies RF-received payload data into fixed-size firmware buffers using memcpy without first verifying that the payload size field does not exceed the destination buffer capacity. In src/rx/crsf.c:91, memcpy(buf + 5, payload, size) uses the attacker-controlled size field directly. In src/rx/unified_crsf.c:284, memcpy(msp_tx_buffer, data, len) similarly uses an unchecked len value. An attacker transmitting a crafted CRSF packet with an oversized size field can overflow the destination buffer, corrupting adjacent memory on the embedded microcontroller.

Changes

  • src/rx/crsf.c
  • src/rx/unified_crsf.c

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

Automated security fix generated by Orbis Security AI
@bkleiner bkleiner merged commit e3d6b4e into BossHobby:develop May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants