Manually added device

[Fabrice35]

Hi,

I have three problems when manually add device :

1. When I manually added device from discover tab, values "Ping Timeout Value" and "Ping Retry Count" are zero.
2. The name of the description field is "FQDN", while the option is not checked in the settings "DPDiscover".
3. When a device is discovered and added to cacti, it goes into "known" in the protocol column.
   When the device is added manually, it remains "CDP"

Thank you very much.

Fabrice

[BotFodder]

1. That's a bug and once I get a chance to go through the code, I'll fix it. It's probably a matter of just pulling the defaults out of the settings before trying to add the device.

2. Hm. The brain is not working well today but I'm guessing I need to either use FQDN or DNS depending on the setting (I'll have to review a bit to figure out what it should do). Again, a bug ... this one might take a bit more to fix since I'll have to look at a bit more of the code and handle conditions properly.

3. This is kind of by design. The "discover" tab results (which you should probably clear out once in a while because it's subject to cruft - there's a thing in System Tools for this I think) are all figured out at the end of a run - it's not updated live. So, if a device is successfully added during a run of dpdiscover, it's considered "known". When you add it manually, the status in the "discover" tab is kept as whatever discover protocol it was discovered as ... until the next run of dpdiscover, at which time it should show up as known.

I think I can change this to be a little more timely (essentially change the status when you go through the add process). This I consider less of a "bug" and more of an "enhancement".

I'll see if I can get them fixed early next week.

[Fabrice35]

3. You're right. Yet I thought doing a discover (findhosts.php) ... Manually added devices are now seen as "protocol known" .... Probably after the polling DPDiscover ...

Sorry.

[BotFodder]

1. This should be fixed in repo (only dpdiscover.php changed).

2. This too should be fixed in repo.

3. This I can't "fix" ... not easily, anyway. The "Add" button pops you into the "host.php" from the main cacti and lets you preview the additions before actually adding the new device. There are problems with either of the solutions in my head (either I have to duplicate the "add" code in the main cacti or you end up with the table saying you added something even if you don't finish the add), so I'm leaving as is.

If you are comfortable with pulling the changes from the master repo, please let me know if the results for 1 and 2 meet with your expectations so I can close the issue with a clean conscience. I'll update the version numbers in setup.php and README just before I close the issue.

[Fabrice35]

It's just perfect !
The "Description" field and the "ping" values are correctly added.

thanks a lot.

[BotFodder]

Closing as "fixed in 1.50". :)

[BotFodder]

Hey - can you do me a favor and pull the master repo and test a change I made?

If you add a device from the report with the provided "description" and "hostname", next time you load the report it should change the "Add" button to the word "ADDED".

If you change either of those values, it would be unable to determine if the host was added as everything stands now.

Perhaps this would be an acceptable alternative to changing the value to "Known" from a discovery protocol?

If it works, I'll update the setup.php/README for a new version.

[BotFodder]

Actually hold off on this I screwed something up ... I'll let you know though when it's ready to test.

[BotFodder]

Okay this should be ready for testing. I actually found a host to test it with on one of my servers, and it worked as I expected.