Merged
Conversation
Co-authored-by: Samuel Buters <sambuters@gmail.com> Co-authored-by: Micaella Gouveia <micaella2212@gmail.com>
Co-authored-by: Eduardo Lima <eduardolima.df@gmail.com> Co-authored-by: Sam Buters <sambuters@gmail.com>
Co-authored-by: Luis Taira <luishptaira@gmail.com> Co-authored-by: Eduardo Lima <eduardolima.df@gmail.com>
Co-authored-by: Sam Buters <sambuters@gmail.com> Co-authored-by: Luis Taira <luishptaira@gmail.com>
CalebeRios
approved these changes
Apr 16, 2019
Collaborator
CalebeRios
left a comment
CalebeRios
left a comment
There was a problem hiding this comment.
Adicionei alguns comentários. Resolvam eles.
| require('./routes')(app); | ||
|
|
||
| app.get('/', (req, res) => { | ||
| res.json({ Hello: 'World' }); |
Collaborator
There was a problem hiding this comment.
Adicionar uma linha em branco entre a linha 16 e 17, e a linha 17 e 18.
src/test/requestCoordsTest.js
Outdated
| should.equal(lat, '-10.3333333'); | ||
| done(); | ||
| }); | ||
| }); |
Collaborator
There was a problem hiding this comment.
.timeout(5000);
De acordo com essa referência: https://stackoverflow.com/questions/15971167/how-to-increase-timeout-for-a-single-test-case-in-mocha
src/test/requestCoordsTest.js
Outdated
| should.equal(lon, '-53.2'); | ||
| done(); | ||
| }); | ||
| }); |
Collaborator
There was a problem hiding this comment.
Mesma coisa do comentário de cima
AmandaMuniz
requested changes
Apr 16, 2019
Contributor
AmandaMuniz
left a comment
AmandaMuniz
left a comment
There was a problem hiding this comment.
Tirem as pastas 'db', 'models' e 'requests' de dentro da 'server'. 'Server' não é um pacote na nossa arquitetura, logo não pode existir.
AmandaMuniz
approved these changes
Apr 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nesse pull request foi feito:
História #4
Issue #64
Conexão da API Gaia-Local com o banco de dados