Conversation
Co-authored-by: Eduardo Lima <eduardolima.df@gmail.com>
Co-authored-by: Eduardo Lima <eduardolima.df@gmail.com>
Co-authored-by: Eduardo Lima <eduardolima.df@gmail.com>
Co-authored-by: Eduardo Lima <eduardolima.df@gmail.com>
Co-authored-by: Eduardo Lima <eduardolima.df@gmail.com>
Co-authored-by: Eduardo Lima <eduardolima.df@gmail.com>
Co-authored-by: Eduardo Lima <eduardolima.df@gmail.com>
Co-authored-by: Eduardo Lima <eduardolima.df@gmail.com>
Co-authored-by: MIcaella Gouveia <micaella2212@gmail.com>
Co-authored-by: Micaella Gouveia <micaella2212@gmail.com>
Co-authored-by: Micaella Gouveia <micaellagouveia2212@gmail.com>
CalebeRios
left a comment
CalebeRios
left a comment
There was a problem hiding this comment.
Tem comentários para alteração. E faltou adicionarem a rota no README. Façam as alterações por favor
src/test/saveNewUserTest.js
Outdated
| local: '', | ||
| notificationDays: '', | ||
| notificationTime: '', | ||
|
|
src/test/saveNewUserTest.js
Outdated
| local: '', | ||
| notificationDays: '', | ||
| notificationTime: '', | ||
|
|
src/index.js
Outdated
|
|
||
| mongooseConnection.connect(); | ||
|
|
||
| app.get('/', (req, res) => { |
There was a problem hiding this comment.
Aproveitem e já alterem essa rota para apresentar as endpoints
| user.findMe().then(() => { | ||
| res.send(user); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Falta uma quebra de linha aqui
| poolSize: 10, | ||
| bufferMaxEntries: 0, | ||
| useNewUrlParser: true, | ||
| }; |
There was a problem hiding this comment.
Falta uma quebra de linha aqui
| notificationDays: String, | ||
| notificationTime: String, | ||
| local: String, | ||
| }); |
There was a problem hiding this comment.
Falta quebra de linha aqui
src/db/userSchema.js
Outdated
| const UserSchema = new mongoose.Schema({ | ||
| telegramId: String, | ||
| sport: String, | ||
| notificationDays: String, |
There was a problem hiding this comment.
Porque isso é do tipo string? Ele deve ser um Array de Strings, pois eu posso salvar assim: quarta, quinta, sexta.
There was a problem hiding this comment.
Tomamos a liberdade de alterar sport, time e local para Array também. Sendo possível agora salvar vários horários, esportes e locais.
src/utils/saveNewUser.js
Outdated
| @@ -0,0 +1,18 @@ | |||
| module.exports = { | |||
|
|
|||
src/utils/endpoints.js
Outdated
| endpoint: '/userRegister', | ||
| parameters: [ | ||
| { | ||
| type: 'JSON', |
There was a problem hiding this comment.
Isso não é nenhum tipo. O que tem dentro desse JSON? Precisa especificar.
Co-authored-by: Ed-vL <eduardolima.df@gmail.com>
AmandaMuniz
left a comment
AmandaMuniz
left a comment
There was a problem hiding this comment.
Esse pr atende todos os critérios de aceitação. A mudança na classe foi aceita e o restante da arquitetura está sendo seguido
|
|
||
| module.exports = class User { | ||
| constructor(telegramId) { | ||
| this.user = new UserModel({ |
There was a problem hiding this comment.
Essa mudança será aceita e o diagrama de classe será refatorado
| return this.user.local[index]; | ||
| } | ||
|
|
||
| saveUser() { |
There was a problem hiding this comment.
Cumpre critério de aceitação de salvar user
| notificationDays: [], | ||
| notificationTime: [], | ||
| local: [], | ||
| }); |
There was a problem hiding this comment.
Cumpre critério de aceitação de salvar preferências de notificação.
Co-authored-by: Eduardo Lima <eduardolima.df@gmail.com>
6 participants
Nesse pull request foi feito:
História #14
Issue #152
Armazenamento de dados de usuarios