Skip to content

Implement Visualizer on top of compiler2_AST#3203

Merged
hellovai merged 2 commits intohellovai/compiler2from
greg/ast-vis
Mar 2, 2026
Merged

Implement Visualizer on top of compiler2_AST#3203
hellovai merged 2 commits intohellovai/compiler2from
greg/ast-vis

Conversation

@imalsogreg
Copy link
Contributor

Graph works despite code errors. The function source code behind this graph has:

  • No closing curly
  • A function call with no closing parenthesis
  • A class constructor with no closing curly
Screenshot 2026-03-02 at 3 24 16 PM

@vercel
Copy link

vercel bot commented Mar 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
beps Ready Ready Preview, Comment Mar 2, 2026 11:44pm
promptfiddle Building Building Preview, Comment Mar 2, 2026 11:44pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • canary

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch greg/ast-vis

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hellovai hellovai merged commit ba2ed74 into hellovai/compiler2 Mar 2, 2026
5 of 6 checks passed
@hellovai hellovai deleted the greg/ast-vis branch March 2, 2026 23:45
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 2, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 15 untouched benchmarks
⏩ 91 skipped benchmarks1


Comparing greg/ast-vis (c700861) with hellovai/compiler2 (3c38f3b)

Open in CodSpeed

Footnotes

  1. 91 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Binary size checks failed

5 violations · ✅ 2 passed

⚠️ Please fix the size gate issues or acknowledge them by updating baselines.

Artifact Platform Gzip Baseline Delta Status
bridge_cffi Linux 4.3 MB 4.0 MB +297.7 KB (+7.5%) OK
bridge_cffi-stripped Linux 2.8 MB 2.5 MB +227.0 KB (+8.9%) FAIL
bridge_cffi macOS 3.5 MB 3.2 MB +317.0 KB (+10.0%) FAIL
bridge_cffi-stripped macOS 2.2 MB 2.0 MB +243.7 KB (+12.4%) FAIL
bridge_cffi Windows 3.5 MB 3.3 MB +211.1 KB (+6.5%) OK
bridge_cffi-stripped Windows 2.3 MB 2.0 MB +255.5 KB (+12.6%) FAIL
bridge_wasm WASM 2.1 MB 2.0 MB +134.3 KB (+6.9%) FAIL
Details & how to fix

Violations:

  • bridge_cffi-stripped (Linux) gzip_bytes: 2.8 MB exceeds limit of 2.6 MB (exceeded by +165.1 KB, policy: max_gzip_bytes)
  • bridge_cffi (macOS) gzip_delta_pct: +10.0% exceeds limit of 10.0% (exceeded by +0.0pp, policy: max_delta_pct)
  • bridge_cffi-stripped (macOS) gzip_delta_pct: +12.4% exceeds limit of 10.0% (exceeded by +2.4pp, policy: max_delta_pct)
  • bridge_cffi-stripped (Windows) gzip_delta_pct: +12.6% exceeds limit of 10.0% (exceeded by +2.6pp, policy: max_delta_pct)
  • bridge_wasm (WASM) gzip_bytes: 2.1 MB exceeds limit of 2.0 MB (exceeded by +90.9 KB, policy: max_gzip_bytes)

Add/update baselines:

.ci/size-gate/aarch64-apple-darwin.toml:

[artifacts.bridge_cffi]
file_bytes = 8170256
stripped_bytes = 8170296
gzip_bytes = 3477055
[artifacts.bridge_cffi-stripped]
file_bytes = 5658496
stripped_bytes = 5658536
gzip_bytes = 2202949

.ci/size-gate/wasm32-unknown-unknown.toml:

[artifacts.bridge_wasm]
file_bytes = 7917320
gzip_bytes = 2090908

.ci/size-gate/x86_64-pc-windows-msvc.toml:

[artifacts.bridge_cffi-stripped]
file_bytes = 5834240
stripped_bytes = 5834240
gzip_bytes = 2277921

.ci/size-gate/x86_64-unknown-linux-gnu.toml:

[artifacts.bridge_cffi-stripped]
file_bytes = 7784976
stripped_bytes = 7784968
gzip_bytes = 2765146

Generated by cargo size-gate · workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants